public inbox for gcc-rust@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Arthur Cohen <arthur.cohen@embecosm.com>,
	 Gaius Mulley <gaiusmod2@gmail.com>,
	gcc-patches@gcc.gnu.org,  gcc-rust@gcc.gnu.org
Subject: Re: [PATCH] testsuite: Add support for Rust and Modula-2 effective target tests
Date: Thu, 15 Dec 2022 12:48:06 +0000 (UTC)	[thread overview]
Message-ID: <nycvar.YFH.7.77.849.2212151247580.5956@jbgna.fhfr.qr> (raw)
In-Reply-To: <Y5sR1W/p4K0CEMRU@tucnak>

On Thu, 15 Dec 2022, Jakub Jelinek wrote:

> Hi!
> 
> This patch allows magic comments also for Rust and Modula-2
> for effective target tests etc. and fixes up the Assembly entry
> - it is a glob, so /* Assembly can match /whatever Assembly and
> not just /* Assembly.
> 
> Tested on x86_64-linux with
> make check-g++ RUNTESTFLAGS=i386.exp=pr35513*
> and verifying it still uses *.S extension for the property_1_needed
> effective target test.
> 
> Ok for trunk?

OK.

Thanks,
Richard.

> 2022-12-15  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* lib/target-supports.exp (check_compile): Add support for
> 	Rust and Modula-2.  Use \* rather than * for /* comment for
> 	Assembly.
> 
> --- gcc/testsuite/lib/target-supports.exp.jj	2022-11-30 10:29:42.217698938 +0100
> +++ gcc/testsuite/lib/target-supports.exp	2022-12-15 13:08:47.941221943 +0100
> @@ -36,7 +36,9 @@
>  # "! Fortran" for Fortran code,
>  # "/* ObjC", for ObjC
>  # "// ObjC++" for ObjC++
> -# and "// Go" for Go
> +# "// Go" for Go
> +# "// Rust" for Rust
> +# and "(* Modula-2" for Modula-2
>  # If the tool is ObjC/ObjC++ then we overide the extension to .m/.mm to 
>  # allow for ObjC/ObjC++ specific flags.
>  
> @@ -58,13 +60,15 @@ proc check_compile {basename type conten
>  	set options ""
>      }
>      switch -glob -- $contents {
> -	"*/* Assembly*" { set src ${basename}[pid].S }
> +	"*/\* Assembly*" { set src ${basename}[pid].S }
>  	"*! Fortran*" { set src ${basename}[pid].f90 }
>  	"*// C++*" { set src ${basename}[pid].cc }
>  	"*// D*" { set src ${basename}[pid].d }
>  	"*// ObjC++*" { set src ${basename}[pid].mm }
>  	"*/* ObjC*" { set src ${basename}[pid].m }
>  	"*// Go*" { set src ${basename}[pid].go }
> +	"*// Rust*" { set src ${basename}[pid].rs }
> +	"*(\* Modula-2*" { set src ${basename}[pid].mod }
>  	default {
>  	    switch -- $tool {
>  		"objc" { set src ${basename}[pid].m }
> 
> 	Jakub
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)

  reply	other threads:[~2022-12-15 12:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 12:23 Jakub Jelinek
2022-12-15 12:48 ` Richard Biener [this message]
2022-12-15 12:53 ` Arthur Cohen
2022-12-15 13:01 ` Andreas Schwab
2022-12-15 13:03 ` Andreas Schwab
2022-12-15 13:22   ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.77.849.2212151247580.5956@jbgna.fhfr.qr \
    --to=rguenther@suse.de \
    --cc=arthur.cohen@embecosm.com \
    --cc=gaiusmod2@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc-rust@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).