From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id AFB4E3858004; Thu, 11 Jan 2024 14:28:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFB4E3858004 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFB4E3858004 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704983312; cv=none; b=P9G7kB+/MJdC+ilZ4xP6g5MR2zVxqwlqH0DRK4MQts3A1f9NYhFnmf4cTHv9nIzTuBDKZKavr8CgEFZa1n9Sy0IVoVMl5wN7LctnFERXM5oLQ4THmjzPD4n50efVh1d3WM4+lkoehu8V5PqEjxVm9HMlEXActI/BgPbGew2Gcuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704983312; c=relaxed/simple; bh=Y6YYECIbTYj8fbcFsNQDDpNv7ZtZeEGmE59t0LjQcSU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=tWvm+Ru98zcjILRYmfVb9C8ynYXdqqQ8sRwoXJph6QOSb/qPX9JzUiEEHAccGBnN645jEIN83xwPLXn35LpjmqfiC9CWz0h9F0STP3kYjYbnshuafW9oPKvC89e8eXaA7U4FFflZxvjQnEJjb940D6KyagTyf7zf15ZRWxjBXmQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8B7ED1FBAC; Thu, 11 Jan 2024 14:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704983309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gB/jrzsqc+ljwfXkiPzwGLandDn0wHj74dOhm9nSxzg=; b=Y80kdcc4uoV10VVO7HG5zg7zPLpXbJJwFYS/itr3lEckQu7jmpaESJHJUg7koBtKhUHMfL Y6uQaWxT/HvSdqT75xRvDf4IOQRqST9P2UCRHPUFmOUhJ6ALtVXxXxl56qDOx18AwS8prX QY9Rs8pDIVccdKBcdgbNEzFFJahqCNM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704983309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gB/jrzsqc+ljwfXkiPzwGLandDn0wHj74dOhm9nSxzg=; b=b2XNcH58yCPONb5VPxK08+1lb/iKdCqNshLANP5MKzVDjEGz99R1gSItYHnTmwnw064phQ dM4ZH6Pc1hRk9LDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704983309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gB/jrzsqc+ljwfXkiPzwGLandDn0wHj74dOhm9nSxzg=; b=Y80kdcc4uoV10VVO7HG5zg7zPLpXbJJwFYS/itr3lEckQu7jmpaESJHJUg7koBtKhUHMfL Y6uQaWxT/HvSdqT75xRvDf4IOQRqST9P2UCRHPUFmOUhJ6ALtVXxXxl56qDOx18AwS8prX QY9Rs8pDIVccdKBcdgbNEzFFJahqCNM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704983309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gB/jrzsqc+ljwfXkiPzwGLandDn0wHj74dOhm9nSxzg=; b=b2XNcH58yCPONb5VPxK08+1lb/iKdCqNshLANP5MKzVDjEGz99R1gSItYHnTmwnw064phQ dM4ZH6Pc1hRk9LDg== Date: Thu, 11 Jan 2024 15:23:28 +0100 (CET) From: Richard Biener To: Arthur Cohen cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org, Pierre-Emmanuel Patry Subject: Re: [PATCH 2/2] gccrs: fixup: Fix missing build dependency In-Reply-To: <20240111142355.1110429-4-arthur.cohen@embecosm.com> Message-ID: References: <20240111142355.1110429-2-arthur.cohen@embecosm.com> <20240111142355.1110429-4-arthur.cohen@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-1.45 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[embecosm.com:email,suse.de:email,makefile.in:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-1.35)[90.47%] X-Spam-Level: X-Spam-Score: -1.45 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 11 Jan 2024, Arthur Cohen wrote: > From: Pierre-Emmanuel Patry > > Fix the missing dependency between the gcc and libgrust. > > ChangeLog: > > * Makefile.def: Add a dependency to libgrust for all-gcc. > * Makefile.in: Regenerate the file. > > Signed-off-by: Pierre-Emmanuel Patry > --- > Makefile.def | 1 + > Makefile.in | 10 ++++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/Makefile.def b/Makefile.def > index 1a256db5518..19954e7d731 100644 > --- a/Makefile.def > +++ b/Makefile.def > @@ -375,6 +375,7 @@ dependencies = { module=configure-gcc; on=all-ld; }; > dependencies = { module=configure-gcc; on=all-gold; }; > dependencies = { module=configure-gcc; on=all-libiconv; }; > dependencies = { module=all-gcc; on=all-libiberty; hard=true; }; > +dependencies = { module=all-gcc; on=all-libgrust; }; That looks wrong? Why is libgrust both a host and a target module? Is that really necessary? IIRC the rust frontend isn't written in rust? The other patch is OK to push. > dependencies = { module=all-gcc; on=all-gettext; }; > dependencies = { module=all-gcc; on=all-mpfr; }; > dependencies = { module=all-gcc; on=all-mpc; }; > diff --git a/Makefile.in b/Makefile.in > index 263b979609b..edb0c8a9a42 100644 > --- a/Makefile.in > +++ b/Makefile.in > @@ -67558,6 +67558,16 @@ all-stagetrain-gcc: all-stagetrain-libiberty > all-stagefeedback-gcc: all-stagefeedback-libiberty > all-stageautoprofile-gcc: all-stageautoprofile-libiberty > all-stageautofeedback-gcc: all-stageautofeedback-libiberty > +all-gcc: maybe-all-libgrust > +all-stage1-gcc: maybe-all-stage1-libgrust > +all-stage2-gcc: maybe-all-stage2-libgrust > +all-stage3-gcc: maybe-all-stage3-libgrust > +all-stage4-gcc: maybe-all-stage4-libgrust > +all-stageprofile-gcc: maybe-all-stageprofile-libgrust > +all-stagetrain-gcc: maybe-all-stagetrain-libgrust > +all-stagefeedback-gcc: maybe-all-stagefeedback-libgrust > +all-stageautoprofile-gcc: maybe-all-stageautoprofile-libgrust > +all-stageautofeedback-gcc: maybe-all-stageautofeedback-libgrust > all-gcc: maybe-all-gettext > all-stage1-gcc: maybe-all-stage1-gettext > all-stage2-gcc: maybe-all-stage2-gettext > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)