From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id B5A0A3861889; Thu, 11 Jan 2024 14:35:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B5A0A3861889 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B5A0A3861889 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704983758; cv=none; b=N7znRWLQn3nnmsVJb5/TmoBVTzJIMudD99MMlujpkbydFhTdRK5OzMYBBmJGf3BmuPLPJbJxkYkPaQtEgPNT7ZWfaoj8URx8a6OPZEF8JneQ41NYKc0t4gq4nPWg1Hu3tAWqGB7NgtuNat/ZArt0ax8Eh3X4yNz0hPC+01/9iII= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704983758; c=relaxed/simple; bh=GbuZcOQCbOQP/kITy0q2HT2F9oXuid00ej3amCjgHUU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=FxF2G9/P3bkBGUn7dp2cVAv3ARdmtB4lvrwZCubwhpo/kT/Hnc2BIHKwzIzxI9J+2L/COcYhIpzJywSDa6DZVIh3VPTagrkxT9y320jk46iTrJSDOVJTxkjBDC7dXS0ySIRedgxtwhz4Zd/AcoNrFXin9noQa4LcMZ1mrSFv6Vs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7C5A51FBAC; Thu, 11 Jan 2024 14:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704983755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yAXqHN1S8Ht9er1rvLF5m1Net0dIz7fce6LjNshHmn4=; b=OpbfTXELLY09KVV9/moRKJGq4jZis9q4xfUHVRWphKL7ejd5WS7eYXyqwYaZW/HSENFj7t TWMNpwyTanC/iPBPMs4bhHHvtMQrS8KA4AY5glbdKpu10wZLTzixn89x5k+7Dfk/SGaT25 F6urYM4pUEh967pYaNamF/FSHCxprwk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704983755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yAXqHN1S8Ht9er1rvLF5m1Net0dIz7fce6LjNshHmn4=; b=3d0XIweVJJFUJ9us1uzqB9Sz6IEt3hNmIfgbF/+r26NSpqxNeJgJKDVlpH7QcVtsYmXcc2 8PmzkT1GdY/BaBDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704983755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yAXqHN1S8Ht9er1rvLF5m1Net0dIz7fce6LjNshHmn4=; b=OpbfTXELLY09KVV9/moRKJGq4jZis9q4xfUHVRWphKL7ejd5WS7eYXyqwYaZW/HSENFj7t TWMNpwyTanC/iPBPMs4bhHHvtMQrS8KA4AY5glbdKpu10wZLTzixn89x5k+7Dfk/SGaT25 F6urYM4pUEh967pYaNamF/FSHCxprwk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704983755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yAXqHN1S8Ht9er1rvLF5m1Net0dIz7fce6LjNshHmn4=; b=3d0XIweVJJFUJ9us1uzqB9Sz6IEt3hNmIfgbF/+r26NSpqxNeJgJKDVlpH7QcVtsYmXcc2 8PmzkT1GdY/BaBDg== Date: Thu, 11 Jan 2024 15:30:54 +0100 (CET) From: Richard Biener To: Arthur Cohen cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org, Pierre-Emmanuel Patry Subject: Re: [PATCH 2/2] gccrs: fixup: Fix missing build dependency In-Reply-To: Message-ID: References: <20240111142355.1110429-2-arthur.cohen@embecosm.com> <20240111142355.1110429-4-arthur.cohen@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-3.10 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[embecosm.com:email,makefile.in:url,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: X-Spam-Score: -3.10 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 11 Jan 2024, Arthur Cohen wrote: > Hi Richard, > > On 1/11/24 15:23, Richard Biener wrote: > > On Thu, 11 Jan 2024, Arthur Cohen wrote: > > > >> From: Pierre-Emmanuel Patry > >> > >> Fix the missing dependency between the gcc and libgrust. > >> > >> ChangeLog: > >> > >> * Makefile.def: Add a dependency to libgrust for all-gcc. > >> * Makefile.in: Regenerate the file. > >> > >> Signed-off-by: Pierre-Emmanuel Patry > >> --- > >> Makefile.def | 1 + > >> Makefile.in | 10 ++++++++++ > >> 2 files changed, 11 insertions(+) > >> > >> diff --git a/Makefile.def b/Makefile.def > >> index 1a256db5518..19954e7d731 100644 > >> --- a/Makefile.def > >> +++ b/Makefile.def > >> @@ -375,6 +375,7 @@ dependencies = { module=configure-gcc; on=all-ld; }; > >> dependencies = { module=configure-gcc; on=all-gold; }; > >> dependencies = { module=configure-gcc; on=all-libiconv; }; > >> dependencies = { module=all-gcc; on=all-libiberty; hard=true; }; > >> +dependencies = { module=all-gcc; on=all-libgrust; }; > > > > That looks wrong? Why is libgrust both a host and a target module? > > Is that really necessary? IIRC the rust frontend isn't written in > > rust? > > libgrust is both a host and target module as it implements some of the parser > functionality - we had to split it from the frontend so that users of the > procedural macro library could use it. So both the host and target link to > that little bit of parser. Does that make sense? I see. OK then. Richard. > Best, > > Arthur > > > > > The other patch is OK to push. > > > >> dependencies = { module=all-gcc; on=all-gettext; }; > >> dependencies = { module=all-gcc; on=all-mpfr; }; > >> dependencies = { module=all-gcc; on=all-mpc; }; > >> diff --git a/Makefile.in b/Makefile.in > >> index 263b979609b..edb0c8a9a42 100644 > >> --- a/Makefile.in > >> +++ b/Makefile.in > >> @@ -67558,6 +67558,16 @@ all-stagetrain-gcc: all-stagetrain-libiberty > >> all-stagefeedback-gcc: all-stagefeedback-libiberty > >> all-stageautoprofile-gcc: all-stageautoprofile-libiberty > >> all-stageautofeedback-gcc: all-stageautofeedback-libiberty > >> +all-gcc: maybe-all-libgrust > >> +all-stage1-gcc: maybe-all-stage1-libgrust > >> +all-stage2-gcc: maybe-all-stage2-libgrust > >> +all-stage3-gcc: maybe-all-stage3-libgrust > >> +all-stage4-gcc: maybe-all-stage4-libgrust > >> +all-stageprofile-gcc: maybe-all-stageprofile-libgrust > >> +all-stagetrain-gcc: maybe-all-stagetrain-libgrust > >> +all-stagefeedback-gcc: maybe-all-stagefeedback-libgrust > >> +all-stageautoprofile-gcc: maybe-all-stageautoprofile-libgrust > >> +all-stageautofeedback-gcc: maybe-all-stageautofeedback-libgrust > >> all-gcc: maybe-all-gettext > >> all-stage1-gcc: maybe-all-stage1-gettext > >> all-stage2-gcc: maybe-all-stage2-gettext > >> > > > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)