From: Danny Smith <dannysmith@clear.net.nz>
To: Richard Henderson <rth@redhat.com>
Cc: gcc@gcc.gnu.org
Subject: Re: stdcall lib functions with exception throwing callbacks vs Dwarf2 EH
Date: Wed, 24 Nov 2004 21:23:00 -0000 [thread overview]
Message-ID: <000b01c4d265$e13c1ec0$424861cb@DANNY> (raw)
In-Reply-To: <20041124184427.GA5485@redhat.com>
Richard Henderson wrote:
> I reproduced this specific failure on linux, and the following seems
> to fix the problem. Can you give it a go with whatever more complex
> test case you have?
>
>
> r~
>
>
> * dwarf2out.c (dwarf2out_stack_adjust): Add after_p argument. Save
> args_size adjustments for calls even with cfa as stack pointer.
> Search calls for stack adjustments after the insn is issued.
> (dwarf2out_frame_debug): Add after_p argument; pass it on.
> * dwarf2out.h (dwarf2out_frame_debug): Update to match.
> * final.c (final_start_function, final_scan_insn): Likewise.
>
Yes it fixes the stdcall testcases.
Out of curiosity I checked to see if it affected
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=6764
which, although closed, has been on-again/off-again with DW2 on windows.
The -mno-accumulate-outgoing-args -fomit-frame-pointer combination
results in abnormal termination with (and without) your patch and the
testcase
in that PR.
Danny
next prev parent reply other threads:[~2004-11-24 20:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-23 22:41 Danny Smith
2004-11-24 0:47 ` Richard Henderson
2004-11-24 7:08 ` Ranjit Mathew
2004-11-24 8:08 ` Danny Smith
2004-11-24 8:26 ` Richard Henderson
2004-11-24 9:41 ` Aaron W. LaFramboise
2004-11-24 17:40 ` Richard Henderson
2004-11-24 18:19 ` Andrew Haley
2004-11-24 8:40 ` Danny Smith
2004-11-24 19:00 ` Richard Henderson
2004-11-24 19:57 ` Andrew Pinski
2004-11-24 20:02 ` Richard Henderson
2004-11-24 21:23 ` Danny Smith [this message]
2004-11-24 6:34 ` Aaron W. LaFramboise
2004-11-24 6:58 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01c4d265$e13c1ec0$424861cb@DANNY' \
--to=dannysmith@clear.net.nz \
--cc=dannysmith@users.sourceforge.net \
--cc=gcc@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).