Re: gcc/gcc version.c

Re: gcc/gcc version.c

[Andrew Pinski]

On Monday, Aug 4, 2003, at 07:53 US/Eastern, mmitchel@gcc.gnu.org wrote:
> CVSROOT:	/cvs/gcc
> Module name:	gcc
> Branch: 	gcc-3_3-branch
> Changes by:	mmitchel@gcc.gnu.org	2003-08-04 11:53:38
>
> Modified files:
> 	gcc            : version.c
>
> Log message:
> 	Update version
>
> Patches:
> http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ 
> version.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3- 
> branch&r1=1.1810.2.239&r2=1.1810.2.240

The bug_report_url is messed up again:

-const char bug_report_url[] = "<URL:http://gcc.gnu.org/bugs.html>";
+const char bug_report_url[] = "3.3.1";

Thanks,
Andrew Pinski

Re: gcc/gcc version.c

[Mark Mitchell]

Don't worry; I'll deal with it.

Thanks,

----- Original Message ----- 
From: "Andrew Pinski" <pinskia@physics.uc.edu>
To: <mmitchel@gcc.gnu.org>
Cc: <gcc@gcc.gnu.org>
Sent: Monday, August 04, 2003 4:55 AM
Subject: Re: gcc/gcc version.c


> On Monday, Aug 4, 2003, at 07:53 US/Eastern, mmitchel@gcc.gnu.org wrote:
> > CVSROOT: /cvs/gcc
> > Module name: gcc
> > Branch: gcc-3_3-branch
> > Changes by: mmitchel@gcc.gnu.org 2003-08-04 11:53:38
> >
> > Modified files:
> > gcc            : version.c
> >
> > Log message:
> > Update version
> >
> > Patches:
> > http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ 
> > version.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3- 
> > branch&r1=1.1810.2.239&r2=1.1810.2.240
> 
> The bug_report_url is messed up again:
> 
> -const char bug_report_url[] = "<URL:http://gcc.gnu.org/bugs.html>";
> +const char bug_report_url[] = "3.3.1";
> 
> Thanks,
> Andrew Pinski
> 
> 

Re: gcc/gcc version.c

[Mark Mitchell]

On Tue, 2003-05-13 at 14:13, Joseph S. Myers wrote:
> On Tue, 13 May 2003 mmitchel@gcc.gnu.org wrote:
> 
> > CVSROOT:	/cvs/gcc
> > Module name:	gcc
> > Branch: 	gcc-3_3-branch
> > Changes by:	mmitchel@gcc.gnu.org	2003-05-13 21:01:59
> > 
> > Modified files:
> > 	gcc            : version.c 
> > 
> > Log message:
> > 	Update version
> > 
> > Patches:
> > http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/version.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.1810.2.154&r2=1.1810.2.155
> 
> This just reset bug_report_url to "3.3" again, rereunning the unfixed
> release script isn't any good here.

Yes, I know; unfortunately, the only 100% reliable way of debugging the
release script is to run it, so until I get it just right we'll go
through this cycle.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com

Re: gcc/gcc version.c

[Joseph S. Myers]

On Tue, 13 May 2003 mmitchel@gcc.gnu.org wrote:

> CVSROOT:	/cvs/gcc
> Module name:	gcc
> Branch: 	gcc-3_3-branch
> Changes by:	mmitchel@gcc.gnu.org	2003-05-13 21:01:59
> 
> Modified files:
> 	gcc            : version.c 
> 
> Log message:
> 	Update version
> 
> Patches:
> http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/version.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.1810.2.154&r2=1.1810.2.155

This just reset bug_report_url to "3.3" again, rereunning the unfixed
release script isn't any good here.

[It also keeps adding to the top of the ChangeLogs every time it's run,
because of the longstanding unfixed bug that it doesn't check if a release
notice for the current version is already at the top of the ChangeLogs.]

-- 
Joseph S. Myers
jsm28@cam.ac.uk

Re: gcc/gcc version.c

[Mark Mitchell]

On Tue, 2003-05-13 at 13:30, Andrew Pinski wrote:
> This messed up the bug_report_url string.

Thanks for noticing!

That indicates a bug in the release script, or rather, that someone
changed version.c in a way that violates an invariant upon which the
release script depends.

I'll fix that.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com

Re: gcc/gcc version.c

[Andrew Pinski]

This messed up the bug_report_url string.

@@ -15,4 +15,4 @@
     forward us bugs reported to you, if you determine that they are
     not bugs in your modifications.)  */

-const char bug_report_url[] = "<URL:http://gcc.gnu.org/bugs.html>";
+const char bug_report_url[] = "3.3";

Thanks,
Andrew Pinski



On Tuesday, May 13, 2003, at 16:24 US/Eastern, mmitchel@gcc.gnu.org  
wrote:

> CVSROOT:	/cvs/gcc
> Module name:	gcc
> Branch: 	gcc-3_3-branch
> Changes by:	mmitchel@gcc.gnu.org	2003-05-13 20:24:39
>
> Modified files:
> 	gcc            : version.c
>
> Log message:
> 	Update version
>
> Patches:
> http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ 
> version.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3- 
> branch&r1=1.1810.2.152&r2=1.1810.2.153
>
>
>