From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 00B283858D33 for ; Wed, 15 Feb 2023 22:30:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00B283858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676500216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U885pg3GO86UIohuQxm4XsSk26oz+DJzKYAphOwas1M=; b=iKujTyneBqeXPxYYKOBZNoU0Ot/CJtnI/K2ytfZTi5VA28c0r5kMc+NChMDP7lNqG8UfkD CEdVIYE9RDKgbXut/9yyR347ZwKY6Iqs1yX/Q6/PuxRpYTIU6zGqB4XXf9Z78bSrmUuzLH G+eAYh+aKWblGSxdSZTmcA4mZiOGBc0= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-631-qN9YnShCM9ywZvxyQGT6Yg-1; Wed, 15 Feb 2023 17:30:15 -0500 X-MC-Unique: qN9YnShCM9ywZvxyQGT6Yg-1 Received: by mail-qv1-f71.google.com with SMTP id c10-20020a05621401ea00b004c72d0e92bcso73245qvu.12 for ; Wed, 15 Feb 2023 14:30:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U885pg3GO86UIohuQxm4XsSk26oz+DJzKYAphOwas1M=; b=IifqOFG617aItitccvU+c2Xdsbj6lYjBugeS5AixPqS7KgwRj694jiq4UMPkdKkgK8 zP8+8q7c++7xYyH0yJpQt2qYNK+H0K8oCOXmSMPnDqiAefeSDlQ49finRPBFLNh78K0r 12eCn7VJ6EJjzPi8DRZaL0hykNlaIDJsWDGFVdLK435nQxy+f3tju7SgCE7gxWOG736d hGh7uk+J3bCBwzp9pj8HncM3rzqbpWCUsC3UOQRzWX3jOCYAJa0o9PGmBagcwAnFMIu8 OdZ8e1g880gQrbKwTCIRxL1w0aru/YqHccSSpIqXeTAI3EFnsPWNITRS7++ukTEZc0IG zfCA== X-Gm-Message-State: AO0yUKU6T9Yio5F187eY5kWvtY0fMpouLGlgua92w4xci4m45gSYmXjq QT1CTje2jRd8XBbSLeQMa4JmsspSkqzIcI4Kc1W+DZ7aPnW3Tglj1V0CjuwCS10SCYrWjNuyRnh l4Swg7js= X-Received: by 2002:a05:6214:b63:b0:537:ab77:fbd3 with SMTP id ey3-20020a0562140b6300b00537ab77fbd3mr8519191qvb.1.1676500214999; Wed, 15 Feb 2023 14:30:14 -0800 (PST) X-Google-Smtp-Source: AK7set/OHGFSOhlAZ+JVK9ssDJUVcenG5eqK+YIg5jpXdkh8vvuhGqG7GSyX8WtEy1mQxT6AN6B48A== X-Received: by 2002:a05:6214:b63:b0:537:ab77:fbd3 with SMTP id ey3-20020a0562140b6300b00537ab77fbd3mr8519165qvb.1.1676500214773; Wed, 15 Feb 2023 14:30:14 -0800 (PST) Received: from ?IPV6:2607:fea8:a263:f600::de2a? ([2607:fea8:a263:f600::de2a]) by smtp.gmail.com with ESMTPSA id t73-20020a37464c000000b007186c9e167esm14728840qka.52.2023.02.15.14.30.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 14:30:14 -0800 (PST) Message-ID: <009a0ac2-0626-c21c-c0f9-4d2e8daa66b3@redhat.com> Date: Wed, 15 Feb 2023 17:30:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: get_range_query vs NULL argument To: Andrew Pinski , Aldy Hernandez , GCC Mailing List References: From: Andrew MacLeod In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/15/23 14:50, Andrew Pinski wrote: > Hi, > While fixing PR 108354, I came across that > ssa_name_has_boolean_range calls get_range_query with cfun as the > argument but sometimes while in IPA passes cfun is currently nullptr. > The question should we check the argument before calling > get_range_query or is it a valid thing to call it with a nullptr (and > have it return global_ranges in that case)? That might be ok...  personally I see nothing wrong with: diff --git a/gcc/value-query.h b/gcc/value-query.h index 63878968118..2d7bf8fcf33 100644 --- a/gcc/value-query.h +++ b/gcc/value-query.h @@ -140,7 +140,7 @@ get_global_range_query ()  ATTRIBUTE_RETURNS_NONNULL inline range_query *  get_range_query (const struct function *fun)  { -  return fun->x_range_query ? fun->x_range_query : &global_ranges; +  return (fun && fun->x_range_query) ? fun->x_range_query : &global_ranges;  }  // Query the global range of NAME in function F.  Default to cfun. The client is probably going to do that anyway. Aldy?