From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id 9CAAA3858D35 for ; Fri, 16 Jun 2023 14:32:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CAAA3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:In-Reply-To:References:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IK8cyatXfxCm/OGBj5Ma4T2nWDmpKxLNAXQfiB0Bgf0=; b=bnCmF3Dfqwhf1ZQ+vabv/4pYui NOh3UWKSgS6LuoceItKlknQwAmugupprYFEGe8FFqH6qGY99djN1v8VXWkUq/J0xQDq3lWP/ATGeZ q9lUhScFZXD1gfFfR9YWqMA/hIIBiwRAeK2+cAxnIEYDKKlnTQdWdY4AtXPbwaOQOLZkRYR3o7LSY pdyofocF+KpoXPnO45fM5Qp4R9qWON3YNs/lAtd9jO6uYwMzYOnl7T/8mDsto6UbWgPpxIlAWuMz9 NhT/WpwzmJMXSiWwInw7ep4HS6WKqTgTVjhbJVd6e025L7QPpnQMSW/skfH1TrtJgwXP/Fv4UV0D1 4ZSQw01g==; Received: from [185.62.158.67] (port=54564 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qAAVG-0000Il-03; Fri, 16 Jun 2023 10:32:42 -0400 From: "Roger Sayle" To: "'Martin Jambor'" Cc: "'GCC Mailing List'" References: In-Reply-To: Subject: RE: Issue generating GCC coverage report since r14-1625-geba3565ce6d766 Date: Fri, 16 Jun 2023 15:32:40 +0100 Message-ID: <015c01d9a05f$68a06660$39e13320$@nextmovesoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGPKpU+JHGLfdsIuPNBTMhEeOL8bLAiZ7XA Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Martin, It's great to hear from you. My apologies for the inconvenience. I believe that the problem has been solved by Jakub's patch: https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;f=3Dgcc/config/i386/i386.= md;h=3D43a3252c42af12ad90082e4088ea58eecd0bf582 I strongly suspect that the problem was that my patch was emitting = "(const_int 0)" as an instruction into the RTL stream, which I'd misunderstood to be = recognized as a no-op by the middle-end. This isn't the case and the correct idiom is = to (also) use: emit_note (NOTE_INSN_DELETED); DONE; I can easily believe that this unintended behaviour is/was interfering = with your code coverage scripts (I should study your posted results). I hope this explains things. Please let me know if things really are = not fixed (or not). Cheers, Roger -- > -----Original Message----- > From: Martin Jambor > Sent: 16 June 2023 13:51 > To: GCC Mailing List > Cc: Roger Sayle > Subject: Issue generating GCC coverage report since = r14-1625-geba3565ce6d766 >=20 > Hello, >=20 > we try to build coverage info for GCC for our testsuite and upload it = to > https://gcc.opensuse.org/gcc-lcov/ every weekend. But since patch > r14-1625-geba3565ce6d766 (Add support for stc and cmc instructions in > i386.md) the generation broke down. However, I don't think there is = something > necessarily wrong with that particular commit, at least I don't see = anything > suspicious. >=20 > I inherited the generating script from Martin Li=C5=A1ka and have not = really looked > much into it much, but it simply does the following after a fresh GCC = master > checkout (I added the --disable-multilib and reduced the number of = languages to > reproduce this more quickly): >=20 >=20 > ../src/configure --prefix=3D/home/mjambor/gcc/mine/inst --enable- > languages=3Dc,c++ --disable-bootstrap --enable-host-shared = --enable-coverage=3Dopt > --disable-multilib > make -j64 && make -j64 -k check > find gcc/testsuite/ -name '*.gcda' -exec rm -rvf {} \; # I don't = know why the > script does this > lcov -d . --capture --output-file gcc.info >=20 >=20 > and this last step, since the commit, when processing file = ./gcc/insn-attrtab.gcda > fails with error: >=20 > geninfo: ERROR: mismatched end line for _Z12get_attr_isaP8rtx_insn = at > /home/mjambor/gcc/mine/src/gcc/config/i386/i386.md:5776: 5776 -> 8963 > (use "geninfo --ignore-errors mismatch ..." to bypass this = error) >=20 > I tried looking briefly into the perl sources of lcov and geninfo but = I am afraid I > don't have the necessary knowledge of the language and the tool or the = time to > properly debug this. So I am inclined to simply add --ignore-errors = mismatch to > lcov options, which avoids the issue, and be done with it. = Nevertheless, I thought > I'd mention this here in case anyone here has any ideas what can be = going wrong. >=20 > Thanks, >=20 > Martin