From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 7D7FF3857831 for ; Fri, 18 Jun 2021 16:40:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D7FF3857831 Received: by mail-ot1-x332.google.com with SMTP id 102-20020a9d0eef0000b02903fccc5b733fso10264268otj.4 for ; Fri, 18 Jun 2021 09:40:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ky5dP9FT3bW0aYECX+AbRjf4goNxcdIw4EWmg+5rsWc=; b=aHHssblSnVAJ4xbuEQUVeIi0GbxBC9wFut4VVmnwF1QoAZfQKUf/9pHa9ajx6JINQZ IEc+eVqPjkz7iuGkQr7jTL0XVXZHL8lKbyFizV3V7aXjufllSOh7Qj8AUbwrdKfL7fCm Dwws/7u2+nqxHd0iYCzz4/1408AUM6gicbP5buBf5JrEvnzu6LJWNJdGCZG8s+nLwV62 zVjSLk9pdDTMU5DfXoe49jWeg+U860Euts0SMBU/HH5b96mGXsgC3fIbllhN72tOlL5o JPhoHKvS15zWRszGKa7TvxKRrCydNupROu2L4LgZVNnVRrFyXakROv8BF/Abx8ilYgME E/9w== X-Gm-Message-State: AOAM5338pYdIdrzjWGM8SaKhK43E6yzIeflNqC82B+DwYUxys5jP3xaK +ssl8agoPToQX5MhXyKJ3D4= X-Google-Smtp-Source: ABdhPJxN/kFmdToQrbjHZeEwvriwgA/ZIuu2egCsjEmLAgQgyQN19lAAhxuDMDBzuzGLxT7WCWDnvg== X-Received: by 2002:a9d:6e99:: with SMTP id a25mr10230989otr.168.1624034441861; Fri, 18 Jun 2021 09:40:41 -0700 (PDT) Received: from [192.168.0.41] (97-118-105-195.hlrn.qwest.net. [97.118.105.195]) by smtp.gmail.com with ESMTPSA id a6sm1912773oon.20.2021.06.18.09.40.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jun 2021 09:40:41 -0700 (PDT) Subject: Re: [Patch] contrib/mklog.py: Improve PR handling To: Tobias Burnus , Jonathan Wakely Cc: Jakub Jelinek , gcc Mailing List , Richard Earnshaw , Joseph Myers References: <71b4a023-efb2-6c6a-9ced-93cce7c96540@gmail.com> <013d6727-4008-b4b5-b793-c782a5ba8e10@redhat.com> <916af0f3-0877-e977-6b6c-899edec8e706@foss.arm.com> <20210617172129.GH7746@tucnak> <16f70de7-8324-e249-dbd8-605022066d12@foss.arm.com> <070f57d5-1496-50f4-1144-3ff2e75a4460@codesourcery.com> <3eaccd30-3c1d-8f62-6382-e3ceb1b4bad2@codesourcery.com> From: Martin Sebor Message-ID: <01eeb5be-809a-182f-fafa-9c3542ea29f8@gmail.com> Date: Fri, 18 Jun 2021 10:40:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <3eaccd30-3c1d-8f62-6382-e3ceb1b4bad2@codesourcery.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 16:40:44 -0000 On 6/18/21 5:25 AM, Tobias Burnus wrote: > On 18.06.21 13:10, Jonathan Wakely wrote: > >> On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: >>> PR c++/12394 - internal compiler error: in write_type, at >>> cp/mangle.c:1517 >>> PR fortran/100123 - -ftree-fre gives incorrect result in subroutine >>> with array declared as length 1 >>>           PR c++/12394 >>>           PR fortran/100123 >> Now that we put these PR cmpt/nnnn lines before the xxx/ChangeLog >> entries, is there any reason to indent them with a TAB? > > My understanding with the PR before vs. after the xxx/ChangeLog is > that if you put them before, they apply to all changelog entries > and if you put them afterward, it only only applies to the those > ChangeLog files for which they have been mentioned. > > (But I also might have misread the code/were misguided by the > var names.) > > And when manually creating the changelog from scratch, they still > often end up after the ChangeLog line. > > But otherwise, I am not attached to the tab. Just one thing: > It might be slightly inconsistent to require the tab after the > xxx/ChangeLog line but not before that line. And I think a > tab should be used after the xxx/ChangeLog line. > >> If we didn't require the TAB before them, then the lines added by -p >> would serve the same purpose, and we wouldn't need to repeat them >> >> So instead of requiring "^\tPR .*/\d+$" for the PR entry, require >> "^\t?PR ([^/]+)/\d+" > I think we should require either ($|\s) after the PR number but > otherwise, it works for me. > > I am sure that Martin Sebor will like this change as he currently > writes changelogs (see in this thread or) like the following one. I do like adding the bug title and extracting the component from Bugzilla. IIRC, Martin Liska implemented -p in mklog.py on my request (although I just discovered the option recently). I was going to propose something similar to your solution: https://gcc.gnu.org/pipermail/gcc/2021-June/236460.html but I'm happy to let you run with it. Thanks Martin > > In that sense, there would be a precedent in terms of actual usage. > > ---------- > Teach compute_objsize about placement new [PR100876]. > > Resolves: > PR c++/100876 - -Wmismatched-new-delete should understand placement new > when it's not inlined > > gcc/ChangeLog: > >        PR c++/100876 > ---------- > > Tobias > > PS: My feeling is that you like the proposed mklog patch :-) > > ----------------- > Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München > Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, > Frank Thürauf