From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id B5D30384F000 for ; Fri, 18 Jun 2021 16:47:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5D30384F000 Received: by mail-ot1-x32c.google.com with SMTP id h24-20020a9d64180000b029036edcf8f9a6so10308144otl.3 for ; Fri, 18 Jun 2021 09:47:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lGvE6qjGaFiKh+n/mBA15RvABPVceE9KpArRr+e73Vg=; b=rO/E2mCExMD4x7xvgj71bWM75WXS2FSa5VjnoF6RL//eC+KYt3kRefcWAMu1OUISHR 78IzRURhyYVZzBfSwUXQbWRUg/mEUNe/TLZBud/7vH44NULT5vpFGnCjabUVJX/T8wFB z7C4+3wvNEI2YV4WBz6Nk/aS9UB6D1Ut3EJvb5shXcVwyy6ibIJGb3iby8WAdByQNZx8 N7aRJg1kD4pszWyP47LjtDLttsVydXadaRxyjVfP2vmLQMzCM2A3h0Bd5jDcBGJm9mpn JV7lG9dTA/gskJ3ImazIWksCLLjFqAMQBCKWnHzhipNqP2MG/UPigHkrcQWk4uXVxwz6 3nRw== X-Gm-Message-State: AOAM530vgS9boDP65zecra/AwPA2dVWFJbTPGzJrkRxA3hIKtLc+YuID waG7xsgKQy6hd4q0+6ZuP7E= X-Google-Smtp-Source: ABdhPJwBDw4tfsa6qBepn7WBeORC6/eGXusIvAM4cXkUiWdXdJhwHVzfc5lQocCEDmWxlpfz1UexfA== X-Received: by 2002:a9d:720a:: with SMTP id u10mr9963519otj.341.1624034865175; Fri, 18 Jun 2021 09:47:45 -0700 (PDT) Received: from [192.168.0.41] (97-118-105-195.hlrn.qwest.net. [97.118.105.195]) by smtp.gmail.com with ESMTPSA id c22sm1703526otp.80.2021.06.18.09.47.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jun 2021 09:47:44 -0700 (PDT) Subject: Re: [Patch] contrib/mklog.py: Improve PR handling To: Jason Merrill , Tobias Burnus Cc: Jakub Jelinek , gcc Mailing List , Richard Earnshaw , Jonathan Wakely , Joseph Myers References: <71b4a023-efb2-6c6a-9ced-93cce7c96540@gmail.com> <013d6727-4008-b4b5-b793-c782a5ba8e10@redhat.com> <916af0f3-0877-e977-6b6c-899edec8e706@foss.arm.com> <20210617172129.GH7746@tucnak> <16f70de7-8324-e249-dbd8-605022066d12@foss.arm.com> <070f57d5-1496-50f4-1144-3ff2e75a4460@codesourcery.com> From: Martin Sebor Message-ID: <01ffe164-bd6a-518a-d10a-803e8ae43ebc@gmail.com> Date: Fri, 18 Jun 2021 10:47:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 16:47:47 -0000 On 6/18/21 8:41 AM, Jason Merrill via Gcc wrote: > On Fri, Jun 18, 2021 at 7:06 AM Tobias Burnus > wrote: > >> On 18.06.21 11:32, Richard Earnshaw via Gcc wrote: >>> On 17/06/2021 18:21, Jakub Jelinek wrote: >>>> mklog as is doesn't fill in the details (descriptions of the changes >>>> to each function etc.), nor is realiable in many cases, and with Jason's >>>> recent change just fills in the first and last part of the first line >>>> but not the important middle part. >>>> So, the developer has to hand edit it anyway and that I'd consider also >>>> be the right time when the verification whether the PR being mentioned >>>> is the right one etc. So no need to add a question asked by the script >>>> at another point. >>> That misses my point. If we use a tool to help doing this we can make >>> the tool also scrape the entry out of bugzilla and print the summary >>> line as a stronger visual check that the number has been typed >>> correctly. We get many bug attributions wrong simply because two digits >>> have been transposed: visually checking the summary line is a far >>> stronger check that the correct number has been entered. >> >> I want to point out that 'mklog -p' already outputs the bug-summary lines >> at the top of the generated changelog, by fetching them from Bugzilla >> >> This patch extends this by: >> * Being able to specify the PR numbers on the command line in addition >> (currently, they are only extracted from the testsuite patches) >> > > This bit seems unnecessary to me, since we want the commit to include tests > that identify the PR. > > Martin Sebor's patch to extract the PR number from the testcase filename, > as an alternative to a comment, should be enough. Just to prevent a deadlock: Tobias, please feel free to reuse any parts of my patch if you wish, or just go with what you have if you prefer. I can submit whatever's left after you're done. Martin