From: "Martin Liška" <mliska@suse.cz>
To: nick <xerofoify@gmail.com>, GCC Development <gcc@gcc.gnu.org>
Subject: Re: FIXME in gcc/gimplify.c
Date: Mon, 01 Apr 2019 08:21:00 -0000 [thread overview]
Message-ID: <050c12a2-9516-5c0a-d7ca-63ee69a7b5ea@suse.cz> (raw)
In-Reply-To: <bcec8fc2-cb0a-7358-ee35-b1a908e8b686@gmail.com>
On 3/29/19 11:29 PM, nick wrote:
> Greetings all,
>
> Not sure why this exists still as tree-eh.h is including in tree-eh.c which defines this header
> as used for this FIXME:
> #include "tree-pass.h" /* FIXME: only for PROP_gimple_any */
>
> Unless there is something in the build ordering that would cause issues it's indirectly including
> that way so this header inclusion should now be removed. Unless I'm missing something else
> which is fine.
>
> If not just let me known and I will just send a patch for it,
> Nick
>
Hi.
Using following patch:
diff --git a/gcc/gimplify.c b/gcc/gimplify.c
index e264700989f..ede679b311c 100644
--- a/gcc/gimplify.c
+++ b/gcc/gimplify.c
@@ -31,7 +31,6 @@ along with GCC; see the file COPYING3. If not see
#include "tm_p.h"
#include "gimple.h"
#include "gimple-predict.h"
-#include "tree-pass.h" /* FIXME: only for PROP_gimple_any */
#include "ssa.h"
#include "cgraph.h"
#include "tree-pretty-print.h"
I get:
g++ -fno-PIE -c -g -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/marxin/Programming/gcc/gcc -I/home/marxin/Programming/gcc/gcc/. -I/home/marxin/Programming/gcc/gcc/../include -I/home/marxin/Programming/gcc/gcc/../libcpp/include -I/home/marxin/Programming/gcc/gcc/../libdecnumber -I/home/marxin/Programming/gcc/gcc/../libdecnumber/bid -I../libdecnumber -I/home/marxin/Programming/gcc/gcc/../libbacktrace -o gimplify.o -MT gimplify.o -MMD -MP -MF ./.deps/gimplify.TPo /home/marxin/Programming/gcc/gcc/gimplify.c
/home/marxin/Programming/gcc/gcc/gimplify.c: In function âgbind* gimplify_body(tree, bool)â:
/home/marxin/Programming/gcc/gcc/gimplify.c:13636:17: error: âTV_TREE_GIMPLIFYâ was not declared in this scope
timevar_push (TV_TREE_GIMPLIFY);
^~~~~~~~~~~~~~~~
/home/marxin/Programming/gcc/gcc/gimplify.c:13636:3: error: âtimevar_pushâ was not declared in this scope
timevar_push (TV_TREE_GIMPLIFY);
^~~~~~~~~~~~
/home/marxin/Programming/gcc/gcc/gimplify.c:13636:3: note: suggested alternative: âtimevalâ
timevar_push (TV_TREE_GIMPLIFY);
^~~~~~~~~~~~
timeval
/home/marxin/Programming/gcc/gcc/gimplify.c:13726:3: error: âtimevar_popâ was not declared in this scope
timevar_pop (TV_TREE_GIMPLIFY);
^~~~~~~~~~~
/home/marxin/Programming/gcc/gcc/gimplify.c:13726:3: note: suggested alternative: âtimevalâ
timevar_pop (TV_TREE_GIMPLIFY);
^~~~~~~~~~~
timeval
/home/marxin/Programming/gcc/gcc/gimplify.c: In function âvoid gimplify_function_tree(tree)â:
/home/marxin/Programming/gcc/gcc/gimplify.c:13792:28: error: âPROP_gimple_lvaâ was not declared in this scope
cfun->curr_properties |= PROP_gimple_lva;
^~~~~~~~~~~~~~~
/home/marxin/Programming/gcc/gcc/gimplify.c:13792:28: note: suggested alternative: âis_gimple_valâ
cfun->curr_properties |= PROP_gimple_lva;
^~~~~~~~~~~~~~~
is_gimple_val
/home/marxin/Programming/gcc/gcc/gimplify.c:13895:28: error: âPROP_gimple_anyâ was not declared in this scope
cfun->curr_properties |= PROP_gimple_any;
^~~~~~~~~~~~~~~
/home/marxin/Programming/gcc/gcc/gimplify.c:13895:28: note: suggested alternative: âwalk_gimple_opâ
cfun->curr_properties |= PROP_gimple_any;
^~~~~~~~~~~~~~~
walk_gimple_op
/home/marxin/Programming/gcc/gcc/gimplify.c: In function âgimplify_status gimplify_va_arg_expr(tree_node**, gimple**, gimple**)â:
/home/marxin/Programming/gcc/gcc/gimplify.c:13988:29: error: âPROP_gimple_lvaâ was not declared in this scope
cfun->curr_properties &= ~PROP_gimple_lva;
^~~~~~~~~~~~~~~
/home/marxin/Programming/gcc/gcc/gimplify.c:13988:29: note: suggested alternative: âis_gimple_valâ
cfun->curr_properties &= ~PROP_gimple_lva;
^~~~~~~~~~~~~~~
is_gimple_val
Martin
next prev parent reply other threads:[~2019-04-01 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 22:29 nick
2019-04-01 8:21 ` Martin Liška [this message]
2019-04-01 16:50 ` nick
2019-04-01 17:54 ` Andrew MacLeod
2019-04-01 21:17 ` nick
2019-04-02 13:33 ` Andrew MacLeod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=050c12a2-9516-5c0a-d7ca-63ee69a7b5ea@suse.cz \
--to=mliska@suse.cz \
--cc=gcc@gcc.gnu.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).