From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7762 invoked by alias); 1 Apr 2019 08:21:24 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 7748 invoked by uid 89); 1 Apr 2019 08:21:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.0 required=5.0 tests=AWL,BAYES_50,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=Programming, inclusion, wwrite-strings, Wwrite-strings X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Apr 2019 08:21:22 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 647A7AE67; Mon, 1 Apr 2019 08:21:20 +0000 (UTC) Subject: Re: FIXME in gcc/gimplify.c To: nick , GCC Development References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <050c12a2-9516-5c0a-d7ca-63ee69a7b5ea@suse.cz> Date: Mon, 01 Apr 2019 08:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00003.txt.bz2 On 3/29/19 11:29 PM, nick wrote: > Greetings all, > > Not sure why this exists still as tree-eh.h is including in tree-eh.c which defines this header > as used for this FIXME: > #include "tree-pass.h" /* FIXME: only for PROP_gimple_any */ > > Unless there is something in the build ordering that would cause issues it's indirectly including > that way so this header inclusion should now be removed. Unless I'm missing something else > which is fine. > > If not just let me known and I will just send a patch for it, > Nick > Hi. Using following patch: diff --git a/gcc/gimplify.c b/gcc/gimplify.c index e264700989f..ede679b311c 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -31,7 +31,6 @@ along with GCC; see the file COPYING3. If not see #include "tm_p.h" #include "gimple.h" #include "gimple-predict.h" -#include "tree-pass.h" /* FIXME: only for PROP_gimple_any */ #include "ssa.h" #include "cgraph.h" #include "tree-pretty-print.h" I get: g++ -fno-PIE -c -g -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/marxin/Programming/gcc/gcc -I/home/marxin/Programming/gcc/gcc/. -I/home/marxin/Programming/gcc/gcc/../include -I/home/marxin/Programming/gcc/gcc/../libcpp/include -I/home/marxin/Programming/gcc/gcc/../libdecnumber -I/home/marxin/Programming/gcc/gcc/../libdecnumber/bid -I../libdecnumber -I/home/marxin/Programming/gcc/gcc/../libbacktrace -o gimplify.o -MT gimplify.o -MMD -MP -MF ./.deps/gimplify.TPo /home/marxin/Programming/gcc/gcc/gimplify.c /home/marxin/Programming/gcc/gcc/gimplify.c: In function ‘gbind* gimplify_body(tree, bool)’: /home/marxin/Programming/gcc/gcc/gimplify.c:13636:17: error: ‘TV_TREE_GIMPLIFY’ was not declared in this scope timevar_push (TV_TREE_GIMPLIFY); ^~~~~~~~~~~~~~~~ /home/marxin/Programming/gcc/gcc/gimplify.c:13636:3: error: ‘timevar_push’ was not declared in this scope timevar_push (TV_TREE_GIMPLIFY); ^~~~~~~~~~~~ /home/marxin/Programming/gcc/gcc/gimplify.c:13636:3: note: suggested alternative: ‘timeval’ timevar_push (TV_TREE_GIMPLIFY); ^~~~~~~~~~~~ timeval /home/marxin/Programming/gcc/gcc/gimplify.c:13726:3: error: ‘timevar_pop’ was not declared in this scope timevar_pop (TV_TREE_GIMPLIFY); ^~~~~~~~~~~ /home/marxin/Programming/gcc/gcc/gimplify.c:13726:3: note: suggested alternative: ‘timeval’ timevar_pop (TV_TREE_GIMPLIFY); ^~~~~~~~~~~ timeval /home/marxin/Programming/gcc/gcc/gimplify.c: In function ‘void gimplify_function_tree(tree)’: /home/marxin/Programming/gcc/gcc/gimplify.c:13792:28: error: ‘PROP_gimple_lva’ was not declared in this scope cfun->curr_properties |= PROP_gimple_lva; ^~~~~~~~~~~~~~~ /home/marxin/Programming/gcc/gcc/gimplify.c:13792:28: note: suggested alternative: ‘is_gimple_val’ cfun->curr_properties |= PROP_gimple_lva; ^~~~~~~~~~~~~~~ is_gimple_val /home/marxin/Programming/gcc/gcc/gimplify.c:13895:28: error: ‘PROP_gimple_any’ was not declared in this scope cfun->curr_properties |= PROP_gimple_any; ^~~~~~~~~~~~~~~ /home/marxin/Programming/gcc/gcc/gimplify.c:13895:28: note: suggested alternative: ‘walk_gimple_op’ cfun->curr_properties |= PROP_gimple_any; ^~~~~~~~~~~~~~~ walk_gimple_op /home/marxin/Programming/gcc/gcc/gimplify.c: In function ‘gimplify_status gimplify_va_arg_expr(tree_node**, gimple**, gimple**)’: /home/marxin/Programming/gcc/gcc/gimplify.c:13988:29: error: ‘PROP_gimple_lva’ was not declared in this scope cfun->curr_properties &= ~PROP_gimple_lva; ^~~~~~~~~~~~~~~ /home/marxin/Programming/gcc/gcc/gimplify.c:13988:29: note: suggested alternative: ‘is_gimple_val’ cfun->curr_properties &= ~PROP_gimple_lva; ^~~~~~~~~~~~~~~ is_gimple_val Martin