From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id BA17C3858D33 for ; Thu, 14 Mar 2024 00:03:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA17C3858D33 Authentication-Results: sourceware.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cloud.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA17C3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710374633; cv=none; b=CSuCj26dreP13jSiguAhTHk4ZSuEyKM+JauhCA7RaFmK8/r7dj1ZqGw3mDJb6ONeAtBWKYYhyQ+vMLcwPsEEG1lwYCZXQ6iQawpRX9nDauulqYSun21lDurGHv6uV5x6crCOFJPYk82tMrnNZTVEhmRUnZZwR0FHtolQ8snzgV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710374633; c=relaxed/simple; bh=8i1suLePlDOXJYuu57mQ2gpHBBXVHafX3SZwqEUm2qU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=yFCCTBoYliXtFKxVv+NMmfoHNNNJcEtUCgshiw0VqEq6Py2+6K7Y/MWlk5e7ioPWnyrIi12CRvEhOg3N/W69BmMISJl4SJkLpWOsLhurnpRXwNjNftccM+v0/U4Y+E7p8c3p0HO3fX0gaZedi45c/FCydYDwOuGZdAF5xHkC/DU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-413e93b0f54so2766145e9.3 for ; Wed, 13 Mar 2024 17:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1710374609; x=1710979409; darn=gcc.gnu.org; h=content-transfer-encoding:autocrypt:subject:from:content-language :to:user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=8i1suLePlDOXJYuu57mQ2gpHBBXVHafX3SZwqEUm2qU=; b=SuX37Ll9bxdvY6BJ40y5b5BXibVXMC3RHTFsT4nvFjbOHg013VppHXv6eI1jiplM+Y qA1hKm9KltUVT5btpz8wUNUIeTPB+EplFfW283MetSsMB6fDbBmpVeScoMhcFxHRlLFz c15/Uu1/G14pd2Kh5hMDX6aG1Xkxa/6Zv6hhA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710374609; x=1710979409; h=content-transfer-encoding:autocrypt:subject:from:content-language :to:user-agent:mime-version:date:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8i1suLePlDOXJYuu57mQ2gpHBBXVHafX3SZwqEUm2qU=; b=cXgofA55123EBG7h+tJpr03Fl1tVb9U+F9PZpG1AAfjPN+2KiZuUuFp/6wudPAz0wZ 9pqwGhbpNY3F3E2XYzZ0cMSrUDPnADvwx8XQokmq4pd+iN9Cn87RRcV53b7ymLOEqRhX 7MFT68IC0jNXtcPEOfRphoiLpo0C0/U0AU0dzTzUzdV/+tES3LgVTl8uBinUQ+I78PK3 LWOmJEa1g1smQzf4T69pzSkMiSf4+5qMHF1CfF4pXpo9E10SJt70Hx672GGTIcZbIWvx 9ucLdSy3uDKq1YgJBex2LTe4smnzDiddxbcNWqTMTWzK1496/nD06DlP/dOXhUmwBUQF D7Rg== X-Gm-Message-State: AOJu0Ywk+B9eDGWXjOprGxBPhp26V1HYUvWLVox2DhvT0Dgjz2xWp9+z Lf4RaBN89uXq2+twFoXcUiQjJ7O3jxWo7qSGmjbdKfuvDNeGC5DttqyFHnfRsMwb9hkD6Az2jjc V X-Google-Smtp-Source: AGHT+IFzuB833C12opSrraP8/LNOr2FKaNRjlm0Db9UZzRnyZDH5+O2py60YjKIXv/RIjQvlr3M+LA== X-Received: by 2002:a05:600c:4e8c:b0:412:a403:e6c9 with SMTP id f12-20020a05600c4e8c00b00412a403e6c9mr173830wmq.5.1710374609350; Wed, 13 Mar 2024 17:03:29 -0700 (PDT) Received: from [192.168.1.10] (host-92-3-248-192.as13285.net. [92.3.248.192]) by smtp.gmail.com with ESMTPSA id n7-20020a05600c3b8700b00413ea3db648sm3343939wms.26.2024.03.13.17.03.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 17:03:28 -0700 (PDT) Message-ID: <06d7af49-c4a9-43d5-a18f-266439c7f82d@citrix.com> Date: Thu, 14 Mar 2024 00:03:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: gcc@gcc.gnu.org Content-Language: en-GB From: Andrew Cooper Subject: Builtin for consulting value analysis (better ffs() code gen) Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, I've come across an issue that I would have thought there would be a builtin for, but perhaps that's just wishful thinking.  I'd like to be able to write something like this:     if (__builtin_expr_is_true(x > 0))         ... // one thing     else         ... // something else This stems from trying to clean up the mess of bit operation helpers in Xen. On x86, __builtin_ffs() doesn't have great code generation.  This is a consequence of the BSF instruction having miserable semantics, and the builtin emits code with a branch or cmov to compensate for undefined case of passing 0 in. On x86_64 at least, Intel and AMD have made enough guarantees in writing to allow a condition-less form:     mov $-1, %dst     bsf %src, %dst     add $1, %dst which is good, but not great.  It is common to have an __ffs() variant which states that a src of 0 is undefined, and while this makes a reasonable improvement to the code generation within loops, it's still not great to rely on the programmer to get this right. A common pattern to find is something like:     while (x) {         int b = ffs(x);         ... // do something with x and b where range analysis can know that x is nonzero.  Indeed, the builtin manages to spot this, and emits a condition-less form too. However, doing this for a local implementation of ffs() doesn't work.  With: unsigned int my_ffs(unsigned int x) {     int res;     if (x) {         asm ("bsf ..." : "=r" (res) : "rm" (x));     } else {         res = -1;         asm ("bsf ..." : "+r" (res) : "rm" (x));     }     return res + 1; } the while() example above really does get generated with ideal form.  However, in general code where the value of x is unknown, the entire if/else chain is emitted, which is strictly worse than just emitting the else case which is the safe catch-all. I suppose that what I'm looking for is something a little like __builtin_constant_p() which can either be used in a straight if(), or in a __builtin_choose_expr(). Anyway - is there a way of doing this that I've managed to overlook? ~Andrew