From: "Martin Liška" <mliska@suse.cz>
To: Jonathan Wakely <jwakely.gcc@gmail.com>,
Jason Merrill <jason@redhat.com>
Cc: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
Nathan Sidwell <nathan@acm.org>,
GCC Development <gcc@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: git: remote: *** The first line of a commit message should be a short description of the change, not a single word.
Date: Wed, 22 Jan 2020 09:26:00 -0000 [thread overview]
Message-ID: <0a2868f4-608c-85a7-b7e7-cdf86873da0a@suse.cz> (raw)
In-Reply-To: <CAH6eHdTPKGXMBLEGpzUwTgPpepBVcRT64kxqadNac=c=3qsoxQ@mail.gmail.com>
On 1/21/20 6:30 PM, Jonathan Wakely wrote:
> Whether they make it to trunk or not doesn't really change the fact
> that a one-word message is poor. If it's only on your local machine,
> do what you like. The hook only complains when such a commit is
> published on gcc.gnu.org.
I would disagree here. I used 'WIP' as my commit message for a branch
that is an experimental and potentially fixes a PR. GCC git is a central
point for my setup, I need to push the branch in order to pull it from
a different machine and test it there.
Moreover, as Jason said, one can have multiple commits that will be
squashed anyway before a patch submission.
Martin
next prev parent reply other threads:[~2020-01-21 19:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 16:45 Martin Liška
2020-01-21 16:58 ` Jonathan Wakely
2020-01-21 17:05 ` Richard Earnshaw (lists)
2020-01-21 17:20 ` Nathan Sidwell
2020-01-21 17:31 ` Richard Earnshaw (lists)
2020-01-21 18:58 ` Jason Merrill
2020-01-21 19:58 ` Jonathan Wakely
2020-01-22 9:26 ` Martin Liška [this message]
2020-01-22 9:38 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a2868f4-608c-85a7-b7e7-cdf86873da0a@suse.cz \
--to=mliska@suse.cz \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=jwakely.gcc@gmail.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).