From: "David E. Weekly" <dweekly@legato.com>
To: "Fergus Henderson" <fjh@cs.mu.oz.au>
Cc: <gcc@gnu.org>
Subject: Re: Patch to Add -Wunused-returns
Date: Thu, 06 Dec 2001 23:32:00 -0000 [thread overview]
Message-ID: <0cca01c17ee6$363cd9e0$5c044589@legato.com> (raw)
In-Reply-To: <20011207170238.A2078@hg.cs.mu.oz.au>
Fergus,
Thanks for your comments!
>>>
I don't see what the point of the second `if' is. Surely the same
warning should be issued for calls via function pointers as is issued for
ordinary calls.
<<<
Good point. And I like your idea of printing the function name, too. Shall I
use this code?
>>>
I'm not sure that close() is a good example here, since checking the
return value from close() for files opened in output mode is very
important, and it would be bad to encourage people to omit that.
<<<
Very fair. How about "strcpy()" as another example of where most people
usually (and rightfully) cast away the return value?
-d
next prev parent reply other threads:[~2001-12-07 6:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-06 22:03 David E. Weekly
2001-12-06 22:14 ` Fergus Henderson
2001-12-06 23:32 ` David E. Weekly [this message]
2001-12-07 2:03 ` Neil Booth
2001-12-07 4:15 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0cca01c17ee6$363cd9e0$5c044589@legato.com' \
--to=dweekly@legato.com \
--cc=fjh@cs.mu.oz.au \
--cc=gcc@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).