From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 919F33858CDB for ; Thu, 4 Apr 2024 08:12:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 919F33858CDB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 919F33858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712218367; cv=none; b=ODK7+CGse2o7PuCmtvClYM5UHmiV8oA7FCMna+q3+qz7eY17rsTUwXKzfneS/IR4HWUlYG3ninqYbaFzfvLKv0XHDGFYqvfnEGGnl2sJWEauUaY7MgQgCI9sKA63zUzEwM2kISW2hNPGRSYWFHkaPDK9XJ1Qkk3/n7STtiBsHsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712218367; c=relaxed/simple; bh=ruh8wSnzCeo2mbBQLBc0eImhcg2/e6vG67GpdqcWa8I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iP0QVjipHaIZjZJGQc5gdC87iFM8GRtUFUuS6toUPh7KGe+OZ/qT4LgINXYCpM+OO98HxLda4thZNGnJ6g3ACa5aOgRpHChXIa69Qe9ZiTmKWqr+rORjwd68HD6T+oBkOui5d6mqDKsYyqD4SaUA0C+4FOnfJtrbIT4VTRm+V/U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-516d04fc04bso157122e87.2 for ; Thu, 04 Apr 2024 01:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1712218364; x=1712823164; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ruh8wSnzCeo2mbBQLBc0eImhcg2/e6vG67GpdqcWa8I=; b=FBRg6m1evmssVUeNLFzejp2+vGOpCNVqc85rRORNizriM9sQsSFrIx0TsKq69pRAXb JZK83no5M76vpAZ/HZzhJEo1MaYcaxnGCqgY7F4PNS7MHZdI6SfmiQ8AGMmRKcTOwJN0 vEDqEFMsCTRQLksGFPXywKQcDygA/M1Cjbqsc9TWQcCHUP2+onNjjvGICX3kkq7AxTdj +9P2jBn9Rt/S8on/UXchZI4ArExLsljIRIMZK+YWULnnjSd3TgqYbyiL1Gqs4NvlbEx3 XxLUXHCk1ytRR5fppzCwkw4K91lS9chnCcMTIuAV6tFA77BEpfS2lmSKZxWEsFhS020p glYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712218364; x=1712823164; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ruh8wSnzCeo2mbBQLBc0eImhcg2/e6vG67GpdqcWa8I=; b=XCG+YSSJOyxw1y+hth9D6BGzLg6sCxseaGa7gbrKQ61VHUjhgB84nf2mpz9AsrXleF 6DiW8MYOxF8FOS7xLkJyqLIPlNu7AJmRSKOS8X3z531MeyNt+Nq20ttZl+CeG1TuNBkq ANzgER0d89n3xNdUYgLYIiWDbR2RzDCfa2QTg2RTJBtoQ5wpXMVLJjtSh1yAI9q1g5eK 8rMoLsQWFGCFTQTjZ1Bi3ZZPKWzD6ZWTKjv2H4G68YpIRmBytDMMsDhF/5GV59nZWmTZ mmR7oE52k0PtVc1m/+2zaXT5zE+cqMzLBTuLhDvf8m/itZjIRXfX6jcKM58lUYCCJCup 7I7Q== X-Forwarded-Encrypted: i=1; AJvYcCU5cNvYOuZBC0CV160rfzryctn4Fws6l54L/d30nVI67b+SQnnkpu8K3MmF3X/tX5k9M4IbtyIs+4t1kJTTSUM= X-Gm-Message-State: AOJu0YzFlZyZUlsvH2U+ErKGFRGyVKW8gd08+QU8lk6AQrSJH38vWtmA vKqL/nm+Gxaj58Mjp0FbJWRY8EbyVZV6q1CJ0xQvo4wfq7I4iWejE3s2XAAvZw== X-Google-Smtp-Source: AGHT+IFAcb+3wlCAnVHgx5jOaHd66Ue+6aIdGRduF3fs5S8Xv3XdqoJtflQiwe2p6pBsQFRGdfpfZw== X-Received: by 2002:ac2:5dd3:0:b0:513:cfcd:f25f with SMTP id x19-20020ac25dd3000000b00513cfcdf25fmr1444671lfq.54.1712218364010; Thu, 04 Apr 2024 01:12:44 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id xe3-20020a170907318300b00a471481ef3csm8659545ejb.124.2024.04.04.01.12.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 01:12:43 -0700 (PDT) Message-ID: <0d343d67-33e0-4f63-b385-8ae360bc68dc@suse.com> Date: Thu, 4 Apr 2024 10:12:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Patches submission policy change Content-Language: en-US To: Christophe Lyon Cc: Maxim Kuvyrkov , Thiago Bauermann , Adhemerval Zanella , binutils@sourceware.org, GCC Mailing List , gdb@sourceware.org, Nick Clifton , Richard Biener , Jakub Jelinek , Joel Brobecker , Carlos O'Donell References: From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03.04.2024 15:11, Christophe Lyon wrote: > On Wed, 3 Apr 2024 at 10:30, Jan Beulich wrote: >> >> On 03.04.2024 10:22, Christophe Lyon wrote: >>> Dear release managers and developers, >>> >>> TL;DR: For the sake of improving precommit CI coverage and simplifying >>> workflows, I’d like to request a patch submission policy change, so >>> that we now include regenerated files. This was discussed during the >>> last GNU toolchain office hours meeting [1] (2024-03-28). >>> >>> Benefits or this change include: >>> - Increased compatibility with precommit CI >>> - No need to manually edit patches before submitting, thus the “git >>> send-email” workflow is simplified >>> - Patch reviewers can be confident that the committed patch will be >>> exactly what they approved >>> - Precommit CI can test exactly what has been submitted >>> >>> Any concerns/objections? >> >> Yes: Patch size. And no, not sending patches inline is bad practice. > Not sure what you mean? Do you mean sending patches as attachments is > bad practice? Yes. It makes it difficult to reply to them (with proper reply context). >> Even assuming sending patches bi-modal (inline and as attachment) works >> (please indicate whether that's the case), it would mean extra work on >> the sending side. >> > For the CI perspective, we use what patchwork is able to detect as patches. > Looking at recent patches submissions, it seems patchwork is able to > cope with the output of git format-patch/git send-email, as well as > attachments. > There are cases where patchwork is not able to detect the patch, but I > don't know patchwork's exact specifications. Question was though: If a patch was sent inline plus attachment, what would CI use as the patch to apply? IOW would it be an option to attach the un-stripped patch, while inlining the stripped one? Jan