public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Daniel Egger <degger@fhm.edu>
To: Daniel Berlin <dberlin@dberlin.org>
Cc: gcc@gcc.gnu.org
Subject: Re: Thoughts on doxygen for internal documentation
Date: Sun, 19 Jan 2003 05:09:00 -0000	[thread overview]
Message-ID: <1042907984.25582.79.camel@sonja> (raw)
In-Reply-To: <Pine.LNX.4.50.0301170402420.3433-100000@dberlin.org>

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Am Fre, 2003-01-17 um 10.10 schrieb Daniel Berlin:

> Not necessarily.
> There are some pretty long macro names in gcc.

[ long explanation omitted ]

Your example is absolutely reasonable and I totally agree that
it's not wise to bend over and invent whatever obfuscated programming
has to offer just to keep it below 80 characters.

Though at the same time

> if (rtx_equal_p (NOTE_VAR_LOCATION_LOC (var1), NOTE_VAR_LOCATION_LOC (var2))

is a perfect example for code which is IMHO easy to misread because from
glancing over it one might miss what exactly happens to be the
condition. If in doubt I'd rather write your example as:

if (rtx_equal_p (NOTE_VAR_LOCATION_LOC (var1),
                 NOTE_VAR_LOCATION_LOC (var2))

-- 
Servus,
       Daniel

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2003-01-18 17:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-15 23:48 Diego Novillo
2003-01-16 10:47 ` Phil Edwards
2003-01-16 18:12 ` law
2003-01-16 18:14   ` Diego Novillo
2003-01-16 18:16     ` law
2003-01-16 18:18       ` Theodore Papadopoulo
2003-01-16 18:57         ` Gabriel Dos Reis
2003-01-16 19:11         ` law
2003-01-16 19:53           ` Andrew Haley
2003-01-16 23:36           ` Toon Moene
2003-01-16 19:18         ` Joel Sherrill
2003-01-16 19:35         ` Marc Espie
2003-01-16 19:37         ` Andrew Haley
2003-01-16 19:57           ` Theodore Papadopoulo
2003-01-17  0:26         ` Daniel Egger
2003-01-17 16:15           ` Daniel Berlin
2003-01-19  5:09             ` Daniel Egger [this message]
2003-01-16 18:20       ` Diego Novillo
2003-01-16 18:27         ` Gabriel Dos Reis
2003-01-16 18:29         ` law
2003-01-16 18:25       ` Daniel Berlin
2003-01-17  4:00     ` Kurt Wall
2003-01-16 20:03   ` Joseph S. Myers
2003-01-17 11:05 ` Tony Finch
2003-01-18 22:21   ` Daniel Egger
2003-01-18 16:17 Robert Dewar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1042907984.25582.79.camel@sonja \
    --to=degger@fhm.edu \
    --cc=dberlin@dberlin.org \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).