Re: libiberty D tuple demangling

[ibuclaw@gdcproject.org]

> On 25/07/2022 08:45 CEST Jan Beulich <jbeulich@suse.com> wrote:
> 
>  
> Hello,
> 
> while commit 3f30a274913b ("libiberty: Update D symbol demangling
> for latest ABI spec") mentions in its description that tuple encoding
> has changed, there's no real adjustment to dlang_parse_tuple() there,
> nor are there any new (or replaced) test cases for that. Was this
> simply overlooked?
> 

Hi Jan,

Is there any specific example that fails to demangle, or are you just skimming?

From what I recall, there is a couple places in the dlang_demangle parser that handle ambiguities in a mangled symbol.  The ABI change only added a terminating 'Z', which makes said code that handles ambiguity redundant - but of course kept around so we handle both old and new symbols.

> Furthermore the current ABI specifies "B Parameters Z". As I don't
> know what the old ABI said, I can only wonder whether the present
> code decoding (in a loop) merely a Type (and not a Parameter) was
> actually correct.
> 

Do you think we should instead be calling dlang_function_args instead?

(Having a quick look at both, that does seem to be the case).

Iain.