From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32120 invoked by alias); 7 May 2003 15:53:42 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 32113 invoked from network); 7 May 2003 15:53:41 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.73.237.138) by sources.redhat.com with SMTP; 7 May 2003 15:53:41 -0000 Received: (qmail 26539 invoked from network); 7 May 2003 15:53:37 -0000 Received: from 227.148-60-66-fuji-dsl.static.surewest.net (HELO ?192.168.0.103?) (mitchell@66.60.148.227) by mail.codesourcery.com with DES-CBC3-SHA encrypted SMTP; 7 May 2003 15:53:37 -0000 Subject: Re: GCC 3.3 Prelease broken on s390 From: Mark Mitchell To: Ulrich Weigand Cc: Richard Henderson , Ulrich Weigand , gcc@gcc.gnu.org In-Reply-To: <200305071449.QAA07836@faui11.informatik.uni-erlangen.de> References: <200305071449.QAA07836@faui11.informatik.uni-erlangen.de> Content-Type: text/plain Organization: CodeSourcery, LLC Message-Id: <1052322820.23765.5.camel@minax.codesourcery.com> Mime-Version: 1.0 Date: Wed, 07 May 2003 15:53:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2003-05/txt/msg00638.txt.bz2 > Unfortunately, while it fixes most of the problems, it is not a > complete solution: Bummer. > Would you suggest to check the above patch in anyway to make 3.3 > more similar to head (apparently the patch is already in 3.2 ...), > and because it fixes at least C++? No, that doesn't seem worth it. > Or should we go back to a RUNTIME_SP_CFA_OFFSET solution > on top of the current 3.3 implementation? That seems fine, if it will work. The key criteria are: (1) You can do it in such a way that it's obvious it doesn't affect other platforms. (2) You can do it quickly. Engineering beauty is not a consideration at all, in this case. #ifdef __s390__ is fine, for example; if you can just do #ifdef __s390__ cfa += 196; #endif that is absolutely fine by me. If we can't meet those criteria, we may be forced to punt; s390 is not a primary evaluation platform. Please see if you can get this fixed in the next twenty-four hours or so. Thanks, -- Mark Mitchell CodeSourcery, LLC