From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19055 invoked by alias); 7 May 2003 16:13:25 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 19044 invoked from network); 7 May 2003 16:13:24 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.73.237.138) by sources.redhat.com with SMTP; 7 May 2003 16:13:24 -0000 Received: (qmail 27459 invoked from network); 7 May 2003 16:13:20 -0000 Received: from 227.148-60-66-fuji-dsl.static.surewest.net (HELO ?192.168.0.103?) (mitchell@66.60.148.227) by mail.codesourcery.com with DES-CBC3-SHA encrypted SMTP; 7 May 2003 16:13:20 -0000 Subject: Re: GCC 3.3 Prelease broken on s390 From: Mark Mitchell To: Joe Buck Cc: Ulrich Weigand , Richard Henderson , Ulrich Weigand , gcc@gcc.gnu.org In-Reply-To: <20030507090113.A7245@synopsys.com> References: <200305071449.QAA07836@faui11.informatik.uni-erlangen.de> <1052322820.23765.5.camel@minax.codesourcery.com> <20030507090113.A7245@synopsys.com> Content-Type: text/plain Organization: CodeSourcery, LLC Message-Id: <1052324004.23765.12.camel@minax.codesourcery.com> Mime-Version: 1.0 Date: Wed, 07 May 2003 16:13:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2003-05/txt/msg00644.txt.bz2 On Wed, 2003-05-07 at 09:01, Joe Buck wrote: > On Wed, May 07, 2003 at 08:53:40AM -0700, Mark Mitchell wrote: > > Engineering beauty is not a consideration at all, in this case. > > > > #ifdef __s390__ is fine, for example; if you can just do > > > > #ifdef __s390__ > > cfa += 196; > > #endif > > > > that is absolutely fine by me. > > If we go for such a solution, I think that it should be a one-release-only > emergency fix, to be replaced ASAP with a better one; seas of #ifdef's > tend to grow if not whacked back. There's no way something like this will go on the mainline. If we had to live with this through the 3.3 series, that would be OK; that is bounded. -- Mark Mitchell CodeSourcery, LLC