From: Diego Novillo <dnovillo@redhat.com>
To: Jan Hubicka <jh@suse.cz>
Cc: Steven Bosscher <stevenb@suse.de>, Jeff Law <law@redhat.com>,
Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>,
Richard Henderson <rth@redhat.com>,
"gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: [tree-ssa] New g++/libstdc++ regressions with checking disabled.
Date: Wed, 10 Dec 2003 22:16:00 -0000 [thread overview]
Message-ID: <1071092808.8617.114.camel@frodo.toronto.redhat.com> (raw)
In-Reply-To: <20031209221600.GF7849@kam.mff.cuni.cz>
On Tue, 2003-12-09 at 17:16, Jan Hubicka wrote:
> >
> > Incidentally, please do not commit any patches that do not fix these
> > regressions.
>
> I've been looking into it with Jason and it seems to be that culprint is
> misscopmilation in cp/class.o (at least replacing it by unoptimized
> version makes the bug to go away).
> The symptom is that method table contains bogus duplicated overload
> entries, so it seems to be somewhere in add_method.
>
Thanks.
I have reverted the patch that introduced these regressions. The branch
is open again.
Diego.
* c-common.c (c_address_looks_like_offsetof): New.
* c-common.h (c_address_looks_like_offsetof): Declare.
* c-typeck.c (build_unary_op) <ADDR_EXPR>: Use it. Don't lower
address references not destined for offsetof.
(c_expand_return): Only look inside ARRAY_REF and COMPONENT_REF
when looking for returning address of local variable.
* expr.c (expand_expr_1): Don't dereference size of unbounded arrays.
* gimplify.c (gimplify_addr_expr): Only fold address of variable size
array elements.
* tree-simple.c (is_gimple_min_invariant): Also check
is_gimple_variable before disallowing offset address for type.
* tree-ssa-ccp.c (maybe_fold_offset_to_aggregate_ref): New.
(maybe_fold_offset_to_component_ref): Use it.
(maybe_fold_stmt_indirect, maybe_fold_stmt_plus): Likewise.
(maybe_fold_offset_to_array_ref): Likewise. Don't fail for division
remainder non-zero.
* varasm.c (initializer_constant_valid_p) <ADDR_EXPR>: Use
handled_component_p and look inside references.
<MINUS_EXPR>: Always look past widening casts.
next prev parent reply other threads:[~2003-12-10 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 18:09 Diego Novillo
2003-12-09 20:31 ` Jan Hubicka
2003-12-09 20:36 ` Diego Novillo
2003-12-09 23:37 ` Jan Hubicka
2003-12-10 22:16 ` Diego Novillo [this message]
2003-12-10 23:01 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1071092808.8617.114.camel@frodo.toronto.redhat.com \
--to=dnovillo@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=jh@suse.cz \
--cc=law@redhat.com \
--cc=rakdver@atrey.karlin.mff.cuni.cz \
--cc=rth@redhat.com \
--cc=stevenb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).