From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22646 invoked by alias); 17 Jan 2004 18:34:11 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 22631 invoked from network); 17 Jan 2004 18:34:09 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sources.redhat.com with SMTP; 17 Jan 2004 18:34:09 -0000 Received: (qmail 12731 invoked from network); 17 Jan 2004 18:33:53 -0000 Received: from 227.148-60-66-fuji-dsl.static.surewest.net (HELO minax.codesourcery.com) (mitchell@66.60.148.227) by mail.codesourcery.com with SMTP; 17 Jan 2004 18:33:53 -0000 Subject: Re: [RFC] Contributing tree-ssa to mainline From: Mark Mitchell To: "Joseph S. Myers" Cc: Daniel Berlin , Florian Weimer , "gcc@gcc.gnu.org" , gcc-patches@gcc.gnu.org In-Reply-To: References: <10401170324.AA15949@vlsi1.ultra.nyu.edu> <1074309907.3147.139.camel@frodo.toronto.redhat.com> <20040117134753.GA14621@deneb.enyo.de> <42BD9D55-48FC-11D8-AECF-000A95DA505C@dberlin.org> Content-Type: text/plain Organization: CodeSourcery, LLC Message-Id: <1074364444.3537.11.camel@minax.codesourcery.com> Mime-Version: 1.0 Date: Sat, 17 Jan 2004 18:34:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg01095.txt.bz2 On Sat, 2004-01-17 at 09:07, Joseph S. Myers wrote: > On Sat, 17 Jan 2004, Daniel Berlin wrote: > > > As Diego stated when SRA was committed, the following limitation exists: > > /* Maximum number of fields that a structure should have to be > > scalarized. > > FIXME This limit has been arbitrarily set to 5. Experiment to find > > a > > sensible setting. */ > > #define MAX_NFIELDS_FOR_SRA 5 > > Before the merge to mainline, please at least change hardcoded parameters > like this to use --param (which does make experimenting with different > values easier). I've understood ever since Mark added that option > that using it > was the convention, it just hasn't been documented as such. OK to commit > the following web page patch? (The beginner.html patch is because it > seems no-one ever took up my suggestion in that thread to add converting > existing parameters to the projects list, and I don't think they've all > been done. Adding comments to parameters that for whatever reason > shouldn't be converted to --param, saying so, would be useful.) Yes, these patches to the docs are OK. -- Mark Mitchell CodeSourcery, LLC