public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Christopher <echristo@redhat.com>
To: Richard Henderson <rth@redhat.com>
Cc: Michael Eager <eager@mvista.com>, gcc <gcc@gcc.gnu.org>
Subject: Re: locking problem with mips atomicity
Date: Tue, 16 Mar 2004 23:33:00 -0000	[thread overview]
Message-ID: <1079479700.3398.14.camel@dzur.sfbay.redhat.com> (raw)
In-Reply-To: <20040316232242.GA6879@redhat.com>

On Tue, 2004-03-16 at 15:22, Richard Henderson wrote:
> On Tue, Mar 16, 2004 at 02:44:15PM -0800, Michael Eager wrote:
> > Well, that's surprising.  I was able to get rid of all of the 
> > other changes. 
> 
> Not ok.  It's not *required* that the compiler reduce all of the
> addresses for you.  In particular, this is more likely to fail
> without optimization.
> 
> > -       : "m" (*__mem), "r"(__val));
> > +       : "m" (*__mem), "r"(__val), "r"(__mem));
> 
> In addition to just adding the new argument, you have to actually
> use it in the assembly.

*shakes head*

I think i'm going to give up for today.

Thanks richard.

-eric

-- 
Eric Christopher <echristo@redhat.com>

  reply	other threads:[~2004-03-16 23:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-15 23:57 Michael Eager
2004-03-16  0:13 ` Phil Edwards
2004-03-16  1:08   ` Michael Eager
2004-03-16  3:12     ` Eric Christopher
2004-03-16  4:57 ` Richard Henderson
2004-03-16 16:10   ` Michael Eager
2004-03-16 17:35     ` Eric Christopher
2004-03-16 17:47       ` Michael Eager
2004-03-16 18:34         ` Richard Henderson
2004-03-16 22:46           ` Michael Eager
2004-03-16 22:49             ` Eric Christopher
2004-03-16 23:27             ` Richard Henderson
2004-03-16 23:33               ` Eric Christopher [this message]
2004-03-17  0:28               ` Michael Eager
2004-03-17  0:51                 ` Phil Edwards
2004-03-17  0:55                   ` Michael Eager
2004-03-17  1:19                     ` Phil Edwards
2004-03-17 22:45                       ` Michael Eager
2004-03-18 12:21                         ` Richard Sandiford
2004-03-18 16:18                           ` Michael Eager
2004-03-18 16:25                           ` Richard Henderson
2004-03-18 16:35                             ` Richard Sandiford
2004-03-17 22:59                       ` Michael Eager
2004-03-18  1:02                         ` Richard Henderson
2004-03-18  7:49                           ` Michael Eager
2004-03-19  8:26                             ` Phil Edwards
2004-03-20  2:56                               ` Michael Eager
2004-03-20  3:39                                 ` Phil Edwards
2004-03-17  1:30                 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1079479700.3398.14.camel@dzur.sfbay.redhat.com \
    --to=echristo@redhat.com \
    --cc=eager@mvista.com \
    --cc=gcc@gcc.gnu.org \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).