public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jim Wilson <wilson@specifixinc.com>
To: Kean Johnston <jkj@sco.com>
Cc: gcc@gcc.gnu.org
Subject: Re: Promoting floats to doubles?
Date: Tue, 04 May 2004 20:52:00 -0000	[thread overview]
Message-ID: <1083703981.1063.14.camel@leaf.tuliptree.org> (raw)
In-Reply-To: <4097D44D.5090105@sco.com>

On Tue, 2004-05-04 at 10:35, Kean Johnston wrote:
> The first case I think should be protected by something like
> #if TARGET_PROMOTES_FLOAT_TO_DOUBLE. My only concern is that I dont
> know if thats the right function to put the conversion in, as I dont
> know all of the circumstances under which default_conversion() is
> called. Perhaps the right thing to do is isolate any changes to
> convert_arguments().

This is why I suggested looking at the old K&R C support, which is
presumably exactly what you need to be compatible with the SCO compiler.

So look at gcc-2.8.1, grep for flag_traditional... I see code in
default_conversion for arguments.  store_parm_decls and
combine_parm_decls for parameters.  And grokdeclarator for return
values.  The last one is optional, since not all K&R C compilers
promoted return values.  So the default_conversion change seems right. 
The store_parm_decls/combine_parm_decls stuff has changed a bit since
2.8.1, so you might have to look at that a bit closer.

> #ifdef TARGET_ALWAYS_PROMOTES_FLOATS
>    else if (TREE_CODE (type) = REAL_TYPE)
>      parmval = convert (double_type_node, parmval);
> #endif

If this is a C front-end specific hook, then putting "always" in the
name is a bit misleading.  Maybe something like
TARGET_KANDRC_PROMOTE_FLOATS.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

  parent reply	other threads:[~2004-05-04 20:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-02  6:32 Kean Johnston
2004-05-03 20:39 ` Jim Wilson
2004-05-04  1:25   ` Kean Johnston
2004-05-04  4:00     ` Jim Wilson
2004-05-04 17:45       ` Kean Johnston
2004-05-04 18:52         ` Joseph S. Myers
2004-05-04 20:44           ` Jim Wilson
2004-05-05  0:06             ` Kean Johnston
2004-05-05  2:18               ` Jim Wilson
2004-05-05  7:10               ` Jim Wilson
2004-05-05  9:10                 ` Kean Johnston
2004-05-05 22:47                   ` Jim Wilson
2004-05-05 23:48                     ` Kean Johnston
2004-05-04 20:52         ` Jim Wilson [this message]
2004-05-05  0:14           ` Kean Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1083703981.1063.14.camel@leaf.tuliptree.org \
    --to=wilson@specifixinc.com \
    --cc=gcc@gcc.gnu.org \
    --cc=jkj@sco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).