public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Christopher <echristo@redhat.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: "Mark Williams (MWP)" <mwp@internode.on.net>,
	gcc@gcc.gnu.org, Mark Mitchell <mark@codesourcery.com>,
	DJ Delorie <dj@redhat.com>
Subject: Re: Error building 4.0.1-RC2
Date: Tue, 21 Jun 2005 22:17:00 -0000	[thread overview]
Message-ID: <1119392192.16400.3.camel@dzur.sfbay.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0506201053530.6452@digraph.polyomino.org.uk>

>  
> If someone wishes to submit a patch for that bug for 4.0 branch, I expect 
> it could be considered for 4.0.2 but might be too risky for 4.0.1 now.
> 

Like so? Tested by building outside the source directory and attempting
to build in the source directory. Did we want something like this for
mainline too?

-eric

2005-06-21  Eric Christopher  <echristo@redhat.com>

	* configure.in: Reject building in the source directory.

Index: configure.in
===================================================================
RCS file: /cvs/gcc/gcc/configure.in,v
retrieving revision 1.341.2.4
diff -u -p -w -r1.341.2.4 configure.in
--- configure.in	6 Jun 2005 06:59:11 -0000	1.341.2.4
+++ configure.in	21 Jun 2005 22:15:20 -0000
@@ -70,6 +70,11 @@ progname=$0
 # if PWD already has a value, it is probably wrong.
 if test -n "$PWD" ; then PWD=`${PWDCMD-pwd}`; fi
 
+# If we're building in the source directory, error.
+if test "${srcdir}" = "." ; then
+  AC_MSG_ERROR([Building in the source directory is not supported. See
http://gcc.gnu.org/install/configure.html for more details.])
+fi
+
 # Export original configure arguments for use by sub-configures.  These
 # will be expanded by make, so quote '$'.
 tmp="$progname $@"


  reply	other threads:[~2005-06-21 22:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-20  5:46 Mark Williams (MWP)
2005-06-20  5:50 ` Eric Christopher
2005-06-20  6:12   ` Mark Williams (MWP)
2005-06-20 10:56     ` Joseph S. Myers
2005-06-21 22:17       ` Eric Christopher [this message]
2005-06-21 22:24         ` DJ Delorie
2005-06-21 22:31           ` Eric Christopher
2005-06-21 22:44             ` Eric Christopher
2005-06-21 22:46               ` DJ Delorie
2005-06-22 14:06         ` Mark Mitchell
2005-06-23  1:09           ` Eric Christopher
  -- strict thread matches above, loose matches on Subject: below --
2005-06-20  5:32 Mark Williams (MWP)
2005-06-20  5:41 ` Eric Christopher
2005-06-20  6:30 ` Ranjit Mathew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1119392192.16400.3.camel@dzur.sfbay.redhat.com \
    --to=echristo@redhat.com \
    --cc=dj@redhat.com \
    --cc=gcc@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=mark@codesourcery.com \
    --cc=mwp@internode.on.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).