From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-116243-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 3730 invoked by alias); 21 Jun 2005 22:17:56 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 3722 invoked by uid 22791); 21 Jun 2005 22:17:52 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 21 Jun 2005 22:17:52 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j5LMGdtY015554;
	Tue, 21 Jun 2005 18:16:39 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j5LMGcu18389;
	Tue, 21 Jun 2005 18:16:38 -0400
Received: from vpn50-3.rdu.redhat.com (vpn50-3.rdu.redhat.com [172.16.50.3])
	by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j5LMGYWM032188;
	Tue, 21 Jun 2005 18:16:35 -0400
Subject: Re: Error building 4.0.1-RC2
From: Eric Christopher <echristo@redhat.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: "Mark Williams (MWP)" <mwp@internode.on.net>, gcc@gcc.gnu.org,
        Mark Mitchell <mark@codesourcery.com>, DJ Delorie <dj@redhat.com>
In-Reply-To: <Pine.LNX.4.61.0506201053530.6452@digraph.polyomino.org.uk>
References: <20050620054650.GA2377@linux.comp>
	 <1119246588.3334.9.camel@dzur.sfbay.redhat.com>
	 <20050620061224.GA22668@linux.comp>
	 <Pine.LNX.4.61.0506201053530.6452@digraph.polyomino.org.uk>
Content-Type: text/plain
Date: Tue, 21 Jun 2005 22:17:00 -0000
Message-Id: <1119392192.16400.3.camel@dzur.sfbay.redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-06/txt/msg00954.txt.bz2

>  
> If someone wishes to submit a patch for that bug for 4.0 branch, I expect 
> it could be considered for 4.0.2 but might be too risky for 4.0.1 now.
> 

Like so? Tested by building outside the source directory and attempting
to build in the source directory. Did we want something like this for
mainline too?

-eric

2005-06-21  Eric Christopher  <echristo@redhat.com>

	* configure.in: Reject building in the source directory.

Index: configure.in
===================================================================
RCS file: /cvs/gcc/gcc/configure.in,v
retrieving revision 1.341.2.4
diff -u -p -w -r1.341.2.4 configure.in
--- configure.in	6 Jun 2005 06:59:11 -0000	1.341.2.4
+++ configure.in	21 Jun 2005 22:15:20 -0000
@@ -70,6 +70,11 @@ progname=$0
 # if PWD already has a value, it is probably wrong.
 if test -n "$PWD" ; then PWD=`${PWDCMD-pwd}`; fi
 
+# If we're building in the source directory, error.
+if test "${srcdir}" = "." ; then
+  AC_MSG_ERROR([Building in the source directory is not supported. See
http://gcc.gnu.org/install/configure.html for more details.])
+fi
+
 # Export original configure arguments for use by sub-configures.  These
 # will be expanded by make, so quote '$'.
 tmp="$progname $@"