public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Daniel Berlin <dberlin@dberlin.org>
To: Laurent GUERBY <laurent@guerby.net>
Cc: Chris Douty <Chris_Douty@ampex.com>,
	gcc@gcc.gnu.org, Richard Henderson <rth@redhat.com>
Subject: Re: Bootstrap failure on powerpc-apple-darwin8 with Ada
Date: Sat, 20 Aug 2005 01:34:00 -0000	[thread overview]
Message-ID: <1124501675.7748.8.camel@linux.site> (raw)
In-Reply-To: <1124491478.7742.328.camel@pc.site>

On Sat, 2005-08-20 at 00:44 +0200, Laurent GUERBY wrote:
> On Sat, 2005-08-20 at 00:36 +0200, Laurent GUERBY wrote:
> > A patch by Andrew Pinski is there:
> > 
> > http://gcc.gnu.org/ml/gcc-patches/2005-07/msg01666.html
> > 
> > But review was negative, so it was not commited.
> > 
> > Hope this helps,
> > 
> > Laurent
> > 
> > PS: is there a PR for this one?
> 
> Thanks to Andrew Pinski for the tip:
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22533

I actually believe Richard may have come up with the wrong idea (using
the analyze_expr hook) because Andrew didn't fully explain what is going
on.

What happens is that the IPA passes, not cgraph, want to analyze
variables, including statics.

If it was just cgraph, i would agree that modifying analyze_expr, is
probably the right solution.

But for general IPA working on the cgraph + GIMPLE level, as is what is
happening here, I think we really need to do something about static
variable initializers so they are in GIMPLE.

Richard, I assume you'd rather have us hack around this for stage3
somehow, and come up with a way to gimplify the static var constructors
for 4.2? (i guess that means creating a new init function and shoving
them in there, and marking it special somehow)
Or do you have another idea?

This is not a case we can just ignore the constructors, they contain
addressof operations we need to be able to see to come up with the right
answers for type escape analysis, static variable address taken, etc :(

--Dan


  reply	other threads:[~2005-08-20  1:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-19 22:17 Chris Douty
2005-08-19 22:37 ` Laurent GUERBY
2005-08-19 22:44   ` Laurent GUERBY
2005-08-20  1:34     ` Daniel Berlin [this message]
2005-08-21  2:16       ` Richard Henderson
2005-08-21  2:33         ` Daniel Berlin
2005-08-22  2:45           ` Richard Henderson
2005-08-22  2:48             ` Andrew Pinski
2005-08-22  3:32             ` Daniel Berlin
2005-08-22  4:27               ` Richard Henderson
2005-08-22 11:38 Richard Kenner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1124501675.7748.8.camel@linux.site \
    --to=dberlin@dberlin.org \
    --cc=Chris_Douty@ampex.com \
    --cc=gcc@gcc.gnu.org \
    --cc=laurent@guerby.net \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).