From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17391 invoked by alias); 23 Nov 2004 19:01:12 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 17327 invoked from network); 23 Nov 2004 19:01:03 -0000 Received: from unknown (HELO mail-out3.apple.com) (17.254.13.22) by sourceware.org with SMTP; 23 Nov 2004 19:01:03 -0000 Received: from mailgate2.apple.com (a17-128-100-204.apple.com [17.128.100.204]) by mail-out3.apple.com (8.12.11/8.12.11) with ESMTP id iANJ7Miw014425 for ; Tue, 23 Nov 2004 11:07:22 -0800 (PST) Received: from relay2.apple.com (relay2.apple.com) by mailgate2.apple.com (Content Technologies SMTPRS 4.3.14) with ESMTP id for ; Tue, 23 Nov 2004 11:01:03 -0800 Received: from [17.219.196.237] ([17.219.196.237]) by relay2.apple.com (8.12.11/8.12.11) with ESMTP id iANJ10kw022368; Tue, 23 Nov 2004 11:01:01 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v619) To: gcc list Message-Id: <117D8646-3D82-11D9-827E-000A95B1F520@apple.com> Content-Type: multipart/signed; micalg=sha1; boundary=Apple-Mail-3-522715383; protocol="application/pkcs7-signature" Cc: Zem Laski Subject: objc data structure design From: Geoffrey Keating Date: Tue, 23 Nov 2004 19:34:00 -0000 X-SW-Source: 2004-11/txt/msg00840.txt.bz2 --Apple-Mail-3-522715383 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Content-length: 1957 Following discussion with Zem, we've agreed that the objc data structure design will proceed as follows: Zem will take this patch: Index: c-tree.h =================================================================== RCS file: /cvs/gcc/gcc/gcc/c-tree.h,v retrieving revision 1.187 diff -u -p -u -p -r1.187 c-tree.h --- c-tree.h 11 Nov 2004 23:13:10 -0000 1.187 +++ c-tree.h 23 Nov 2004 18:54:26 -0000 @@ -73,6 +73,8 @@ struct lang_type GTY(()) /* In an ENUMERAL_TYPE, the min and max values. */ tree enum_min; tree enum_max; + /* In a RECORD_TYPE, . */ + tree objc_protocol; }; /* Record whether a type or decl was written with nonconstant size. Index: cp/cp-tree.h =================================================================== RCS file: /cvs/gcc/gcc/gcc/cp/cp-tree.h,v retrieving revision 1.1070 diff -u -p -u -p -r1.1070 cp-tree.h --- cp/cp-tree.h 10 Nov 2004 17:34:47 -0000 1.1070 +++ cp/cp-tree.h 23 Nov 2004 18:54:28 -0000 @@ -1060,6 +1060,9 @@ struct lang_type_class GTY(()) tree decl_list; tree template_info; tree befriending_classes; + + /* . */ + tree objc_protocol; }; struct lang_type_ptrmem GTY(()) (with comments and possibly field names improved), and determine what impact it has on C and C++ compile time, and C and C++ PCH size. For C++, he'll use our Finder_FE benchmark for both time and PCH size, for C I suggest that the PCH be one that just contains #include on Darwin, and use some reasonable and convenient benchmark for time. If these results show that there's not significant degradation, that is less than 1% for compile speed and increase in PCH size, then this should solve his problem and let him proceed with the objc data structure changes. If there is significant degradation, we'll look at making these fields be inserted only when they're actually needed. --Apple-Mail-3-522715383 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s Content-length: 3266 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEH AQAAoIIGQzCCAvwwggJloAMCAQICAwykzzANBgkqhkiG9w0BAQQFADBiMQsw CQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkg THRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3Vp bmcgQ0EwHhcNMDQwNzA3MjEwNTI1WhcNMDUwNzA3MjEwNTI1WjBxMRAwDgYD VQQEEwdLZWF0aW5nMRkwFwYDVQQqExBHZW9mZnJleSBGcmFuY2lzMSEwHwYD VQQDExhHZW9mZnJleSBGcmFuY2lzIEtlYXRpbmcxHzAdBgkqhkiG9w0BCQEW EGdlb2Zma0BhcHBsZS5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEK AoIBAQCk+DpeD1oRuwCyKEyWI1+V9N7wt58WtqjfjF2oVb7OCh3Oq34nHQAT 76qdibJabSf213HPwAU/D3BnLtWldIiKy46xPvmUzbhfwZbq7DXGjQ1ishvo H5jzI4YMKmVf3ggSAtVTyd8WU0xvhFe3iOMfnyPGoPdbjQFkVaLlhJ7Xv2hu IK6ZYHdCsQ4B2u3V4ObkgZIg+CkwGuZb/l1JIc4tjixMNk81Pp4GtG8pWU5y SbP3LpHUDLQyK8Kg3+WfqKqdcZPJJpilaEZtS+mysgFymB0mKruAMmLfs0mT FflblEqacY7W/Zkr9yn5xTNsLEk6nhXYAccAuK2HDx4n+pIhAgMBAAGjLTAr MBsGA1UdEQQUMBKBEGdlb2Zma0BhcHBsZS5jb20wDAYDVR0TAQH/BAIwADAN BgkqhkiG9w0BAQQFAAOBgQBJ1U1y72DgkFZGAeUHwnIGD5+97AYpgTsY0GpF j8gEx09sFQ5Ay+9glApR0kFuC+4wEqCVfXhxqlBrEWXA0+j9Gq6O4uLchtW4 y40TUYaQCP8H4t0FUWdueXfe8KtCwXZlrExqrWQeIv5YIiUqYmsyctg1tex+ m74ZI0u8gorLITCCAz8wggKooAMCAQICAQ0wDQYJKoZIhvcNAQEFBQAwgdEx CzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUxEjAQBgNVBAcT CUNhcGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcxKDAmBgNV BAsTH0NlcnRpZmljYXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMT G1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBDQTErMCkGCSqGSIb3DQEJARYc cGVyc29uYWwtZnJlZW1haWxAdGhhd3RlLmNvbTAeFw0wMzA3MTcwMDAwMDBa Fw0xMzA3MTYyMzU5NTlaMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3 dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVy c29uYWwgRnJlZW1haWwgSXNzdWluZyBDQTCBnzANBgkqhkiG9w0BAQEFAAOB jQAwgYkCgYEAxKY8VXNV+065yplaHmjAdQRwnd/p/6Me7L3N9VvyGna9fww6 YfK/Uc4B1OVQCjDXAmNaLIkVcI7dyfArhVqqP3FWy688Cwfn8R+RNiQqE88r 1fOCdz0Dviv+uxg+B79AgAJk16emu59l0cUqVIUPSAR/p7bRPGEEQB5kGXJg t/sCAwEAAaOBlDCBkTASBgNVHRMBAf8ECDAGAQH/AgEAMEMGA1UdHwQ8MDow OKA2oDSGMmh0dHA6Ly9jcmwudGhhd3RlLmNvbS9UaGF3dGVQZXJzb25hbEZy ZWVtYWlsQ0EuY3JsMAsGA1UdDwQEAwIBBjApBgNVHREEIjAgpB4wHDEaMBgG A1UEAxMRUHJpdmF0ZUxhYmVsMi0xMzgwDQYJKoZIhvcNAQEFBQADgYEASIzR UIPqCy7MDaNmrGcPf6+svsIXoUOWlJ1/TCG4+DYfqi2fNi/A9BxQIJNwPP2t 4WFiw9k6GX6EsZkbAMUaC4J0niVQlGLH2ydxVyWN3amcOY6MIE9lX5Xa9/eH 1sYITq726jTlEBpbNU1341YheILcIRk13iSx0x1G/11fZU8xggLnMIIC4wIB ATBpMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGlu ZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1h aWwgSXNzdWluZyBDQQIDDKTPMAkGBSsOAwIaBQCgggFTMBgGCSqGSIb3DQEJ AzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTA0MTEyMzE5MDEyM1ow IwYJKoZIhvcNAQkEMRYEFF03jjpw38DFYLkgYGzfn8Bb4klJMHgGCSsGAQQB gjcQBDFrMGkwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25z dWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBG cmVlbWFpbCBJc3N1aW5nIENBAgMMpM8wegYLKoZIhvcNAQkQAgsxa6BpMGIx CzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5 KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNz dWluZyBDQQIDDKTPMA0GCSqGSIb3DQEBAQUABIIBAC961XJKLFwmnICEqHdT /hhENBZnCfQNK1qZULoqhyOUpfD+ESoAje/Kj9AMyIi3EBpL7EtVHVmQklmZ R9oQFL1G44EOh4fiH7vmAkn9fhgguba4PIsmJAcIOxvPKTs2Fx1bbWjlcdDj ttffKKdk06n+kQBeqptntuyhCnnVne7F9tTNOZZoJnTrfjfT5/LlqLXz3i6m F0CqohWpTbTmBMcx04SluR+auEEO4HPM4I38LEK0XZbON2F3iUCUWxa6ypng rfhQiqAHDpDdFxlRPexrsF16gMsEl6AghIj7xgcQ78F1uAe65CLSJoihm8+3 25zxQtZ4WTtidl8LmcrZm/4AAAAAAAA= --Apple-Mail-3-522715383--