From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25218 invoked by alias); 4 May 2009 05:31:31 -0000 Received: (qmail 25205 invoked by uid 22791); 4 May 2009 05:31:30 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailout02.t-online.de (HELO mailout02.t-online.de) (194.25.134.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 May 2009 05:31:23 +0000 Received: from fwd00.aul.t-online.de by mailout02.sul.t-online.de with smtp id 1M0ql9-0005l4-00; Mon, 04 May 2009 07:30:35 +0200 Received: from [192.168.178.27] (rA1fsiZFZhvTSr6wRvlZWT0CON9sr1Rl+eh0bCAODv6eClmqBOouBxu1FHnkKniwLy@[84.156.201.79]) by fwd00.aul.t-online.de with esmtp id 1M0qkv-0mmnyq0; Mon, 4 May 2009 07:30:21 +0200 Subject: Re: [gnat] reuse of ASTs already constructed From: oliver.kellogg@t-online.de (Oliver Kellogg) Reply-To: okellogg@users.sourceforge.net To: Robert Dewar Cc: gcc@gcc.gnu.org In-Reply-To: <49FE415A.5050601@adacore.com> References: <1239557374.7565.37.camel@tidbit.site> <1240083309.4554.45.camel@tidbit.site> <1240175954.4554.50.camel@tidbit.site> <1241385654.4763.38.camel@tidbit.site> <49FE09D9.4090702@adacore.com> <1241386066.4763.42.camel@tidbit.site> <49FE415A.5050601@adacore.com> Content-Type: text/plain Date: Mon, 04 May 2009 05:31:00 -0000 Message-Id: <1241415395.21122.14.camel@tidbit.site> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-05/txt/msg00060.txt.bz2 Robert Dewar wrote: > > I don't see that Str3 is free in any of these nodes, what > nodes are you talking about (remember that Str3 overlaps > Node3, List3 etc). Okay. > >>>> How about not doing the name expansion in-place but rather > >>>> storing the expanded name in an extra node field? > > You could have a separate vector for expanded names I suppose ... So be it. I will change the code to not overwrite the Name field with the expanded name but rather store the expanded name in a data structure separate from the Node. Any thoughts on my questions related to gnatmake? Further question, what is the process for integrating my changes into the GCC trunk? I would assume that I need to 1) Make my modifications complete and functioning 2) Make sure bootstrap works for all languages 3) Run the gcc testsuite and make sure I do not introduce regressions 4) What about testing on different platforms? I'm only testing on x86 SuSE Linux and setting up other platforms could be a problem. (Coming to think, I could actually test on x86_64 SuSE Linux with small effort, though.) 5) Copyright assignment should be on file at FSF, please check 6) Anything else? Thanks, Oliver