Re: new libstdc++-v3 decimal failures

Re: new libstdc++-v3 decimal failures

[Benjamin Kosnik]

Why do we have a libstdc++ list? For questions like this...

> > > > FAIL: decimal/binary-arith.cc (test for excess errors)

plus

> However, the testsuite failures still occurs as follows...
> 
> Executing on
> host: /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/./gcc/g++
> -shared-libgcc
> from /sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/testsuite/decimal/binary->
> arith.cc:22:0: /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++->
> v3/include/decimal/decimal:39:2:
> error: #error This file requires compiler and library support for
> ISO/IEC TR 24733 that is currently not
> available. /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/>
> include/decimal/decimal:228:56:
> error: unable to emulate
> 'SD' /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/>
> decimal/decimal:249:5:
> error:
> 'std::decimal::decimal32::decimal32(std::decimal::decimal32::__decfloat32)'
> cannot be
> overloaded /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/>
> include/decimal/decimal:236:14:
> error: with 'std::decimal::decimal32::decimal32(float)'
 
...means that it's the excess error that is the fail. Not the error.

On the brightside, the error is better now, I think.

> etc...for about a hundred errors. Doesn't this imply that the dejagnu
> test harness isn't properly recognizing the absence of the decimal
> support?

I changed this from what Janis posted, so she is certainly not to blame
here. In any case, all you should have to do is add a new line for this
new error:

> error: #error This file requires compiler and library support for
> ISO/IEC TR 24733 that is currently not
> available. 

-benjamin

Re: new libstdc++-v3 decimal failures

[Jack Howarth]

On Tue, Oct 06, 2009 at 03:34:30PM -0700, Benjamin Kosnik wrote:
> 
> Why do we have a libstdc++ list? For questions like this...
> 
  Because this is a flaw in the libstdc++-v3 testsuite harness
which obviously the core gcc testsuite handles properly. The
other gcc developers might have an insight on the best way
to fix this for libstdc++-v3 (since it appears you need some
of the procs from gcc/testsuite/lib/target-supports.exp).
            Jack

Re: new libstdc++-v3 decimal failures

[Janis Johnson]

On Tue, 2009-10-06 at 18:56 -0400, Jack Howarth wrote:
> On Tue, Oct 06, 2009 at 03:34:30PM -0700, Benjamin Kosnik wrote:
> > 
> > Why do we have a libstdc++ list? For questions like this...
> > 
>   Because this is a flaw in the libstdc++-v3 testsuite harness
> which obviously the core gcc testsuite handles properly. The
> other gcc developers might have an insight on the best way
> to fix this for libstdc++-v3 (since it appears you need some
> of the procs from gcc/testsuite/lib/target-supports.exp).

Actually it's a flaw in my new tests, a missing space in
// { dg-require-effective-target dfp }

Patch will be checked in momentarily; sorry about that.

By the way, gcc/testsuite/lib/target-supports-dg.exp is
included indirectly, and the check doesn't look for any
specific error message.

Janis

Re: new libstdc++-v3 decimal failures

[Jack Howarth]

On Tue, Oct 06, 2009 at 03:40:29PM -0700, Janis Johnson wrote:
> 
> I spoke too soon.  I'm now building a compiler with decimal float
> disabled and will dig into this.
> 
> Janis

Janis,
   Don't you have to include something like gcc/testsuite/lib/target-supports.exp
to be able to use check_effective_target_dfp? I am somewhat surprised that
the dejagnu harness didn't throw an error when trying to process...

// { dg-require-effective-target-dfp }

without having a "load_lib target-supports.exp" in the calling .exp script.

                Jack

Re: new libstdc++-v3 decimal failures

[Janis Johnson]

On Tue, 2009-10-06 at 15:30 -0700, Janis Johnson wrote:
> On Tue, 2009-10-06 at 18:19 -0400, Jack Howarth wrote:
> > On Tue, Oct 06, 2009 at 09:44:42AM -0700, Janis Johnson wrote:
> > > On Tue, 2009-10-06 at 09:10 -0700, Janis Johnson wrote:
> > > > On Tue, 2009-10-06 at 09:04 -0400, Jack Howarth wrote:
> > 
> > etc...for about a hundred errors. Doesn't this imply that the dejagnu test harness isn't properly recognizing the absence of
> > the decimal support?
> 
> Oh, maybe the libstdc++ tests don't support dg-require-effective-target.

I spoke too soon.  I'm now building a compiler with decimal float
disabled and will dig into this.

Janis

Re: new libstdc++-v3 decimal failures

[Jack Howarth]

On Tue, Oct 06, 2009 at 03:30:34PM -0700, Janis Johnson wrote:
> 
> Oh, maybe the libstdc++ tests don't support dg-require-effective-target.
> 
> Janis

Janis,
   Yes, doesn't it need something like...

# Skip these tests for targets that don't support this extension.
if { ![check_effective_target_dfp] } {
    return;
}

which is in testsuite/gcc.dg/dfp/dfp.exp. I find...

grep -R check_effective_target_dfp testsuite | grep ".exp" | grep -v svn | grep -v Change
testsuite/g++.dg/dfp/dfp.exp:if { ![check_effective_target_dfp] } {
testsuite/g++.dg/dfp/dfp.exp:if { ![check_effective_target_dfprt] } {
testsuite/gcc.dg/dfp/dfp.exp:if { ![check_effective_target_dfp] } {
testsuite/gcc.dg/dfp/dfp.exp:if { ![check_effective_target_dfprt] } {
testsuite/gcc.misc-tests/dectest.exp:if { ![check_effective_target_dfp] } {
testsuite/lib/c-compat.exp:    set compat_have_dfp [check_effective_target_dfprt_nocache]
testsuite/lib/c-compat.exp:	set compat_have_dfp [check_effective_target_dfprt_nocache]
testsuite/lib/target-supports.exp:proc check_effective_target_dfp_nocache { } {
testsuite/lib/target-supports.exp:    verbose "check_effective_target_dfp_nocache: compiling source" 2
testsuite/lib/target-supports.exp:    verbose "check_effective_target_dfp_nocache: returning $ret" 2
testsuite/lib/target-supports.exp:proc check_effective_target_dfprt_nocache { } {
testsuite/lib/target-supports.exp:proc check_effective_target_dfp { } {
testsuite/lib/target-supports.exp:	check_effective_target_dfp_nocache
testsuite/lib/target-supports.exp:proc check_effective_target_dfprt { } {
testsuite/lib/target-supports.exp:	check_effective_target_dfprt_nocache

but for libstdc++-v3...

grep -R check_effective_target_dfp testsuite | grep ".exp" | grep -v svn | grep -v Change

nothing appears.
           Jack

Re: new libstdc++-v3 decimal failures

[Janis Johnson]

On Tue, 2009-10-06 at 18:19 -0400, Jack Howarth wrote:
> On Tue, Oct 06, 2009 at 09:44:42AM -0700, Janis Johnson wrote:
> > On Tue, 2009-10-06 at 09:10 -0700, Janis Johnson wrote:
> > > On Tue, 2009-10-06 at 09:04 -0400, Jack Howarth wrote:
> > > > Janis,
> > > >    We are seeing failures of the new decimal testcases on x86_64-apple-darwin10
> > > > which you committed into the libstdc++-v3 testsuite...
> > > > 
> > > > FAIL: decimal/binary-arith.cc (test for excess errors)
> > > > WARNING: decimal/binary-arith.cc compilation failed to produce executable
> > > <lots more failures>
> > > > 
> > > > Are these tests entirely glibc-centric and shouldn't they be disabled for
> > > > darwin?
> > > 
> > > Each test contains
> > > 
> > >   // { dg-require-effective-target-dfp }
> > > 
> > > which checks that the compiler supports modes SD, DD, and TD, which
> > > in turn are supported if ENABLE_DECIMAL_FLOAT is defined within the
> > > compiler.  That should not be defined for darwin; I'll take a look.
> > 
> > I built a cross cc1plus for x86_64-apple-darwin10 and got the behavior
> > I expected.  From $objdir/gcc:
> > 
> > elm3b149% fgrep -l ENABLE_DECIMAL_FLOAT *.h
> > auto-host.h:#define ENABLE_DECIMAL_FLOAT 0
> > 
> > elm3b149% echo "float x __attribute__((mode(DD)));" > x.c
> > elm3b149% ./cc1plus -quiet x.c
> > x.c:1:33: error: unable to emulate ‘DD’
> > 
> > Please try that little test with your cc1plus to see if the problem
> > is with your compiler not rejecting DD mode, or with the test
> > framework not handling it correctly.
> > 
> > Janis
> 
> Janis,
>    I find that ENABLE_DECIMAL_FLOAT is set to 0 on x86_64-apple-darwin10...
> 
> [MacPro:gcc45-4.4.999-20091005/darwin_objdir/gcc] root# grep ENABLE_DECIMAL_FLOAT auto-host.h
> #define ENABLE_DECIMAL_FLOAT 0
> 
> and the test code fails to compile...
> 
> [MacPro:gcc45-4.4.999-20091005/darwin_objdir/gcc] root# echo "float x __attribute__((mode(DD)));" > x.c
> [MacPro:gcc45-4.4.999-20091005/darwin_objdir/gcc] root# ./cc1plus -quiet x.c
> x.c:1:33: error: unable to emulate ‘DD’
> 
> However, the testsuite failures still occurs as follows...
> 
> Executing on host: /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/./gcc/g++ -shared-libgcc -B/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/./gcc -nostdinc++ -L/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/src -L/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/src/.libs -B/sw/lib/gcc4.5/x86_64-apple-darwin10.0.0/bin/ -B/sw/lib/gcc4.5/x86_64-apple-darwin10.0.0/lib/ -isystem /sw/lib/gcc4.5/x86_64-apple-darwin10.0.0/include -isystem /sw/lib/gcc4.5/x86_64-apple-darwin10.0.0/sys-include -g -O2 -D_GLIBCXX_ASSERT -fmessage-length=0 -ffunction-sections -fdata-sections -g -O2 -g -O2 -DLOCALEDIR="." -nostdinc++ -I/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/x86_64-apple-darwin10.0.0 -I/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include -I/sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/libsupc++ -I/sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/include/backward -I/sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/testsuite/util /sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/testsuite/decimal/binary-arith.cc    -include bits/stdc++.h ./libtestc++.a -L/sw/lib -liconv  -lm   -o ./binary-arith.exe    (timeout = 600)
> In file included from /sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/testsuite/decimal/binary-arith.cc:22:0:
> /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/decimal/decimal:39:2: error: #error This file requires compiler and library support for ISO/IEC TR 24733 that is currently not available.
> /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/decimal/decimal:228:56: error: unable to emulate 'SD'
> /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/decimal/decimal:249:5: error: 'std::decimal::decimal32::decimal32(std::decimal::decimal32::__decfloat32)' cannot be overloaded
> /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/decimal/decimal:236:14: error: with 'std::decimal::decimal32::decimal32(float)'
> 
> etc...for about a hundred errors. Doesn't this imply that the dejagnu test harness isn't properly recognizing the absence of
> the decimal support?

Oh, maybe the libstdc++ tests don't support dg-require-effective-target.

Janis

Re: new libstdc++-v3 decimal failures

[Jack Howarth]

On Tue, Oct 06, 2009 at 09:44:42AM -0700, Janis Johnson wrote:
> On Tue, 2009-10-06 at 09:10 -0700, Janis Johnson wrote:
> > On Tue, 2009-10-06 at 09:04 -0400, Jack Howarth wrote:
> > > Janis,
> > >    We are seeing failures of the new decimal testcases on x86_64-apple-darwin10
> > > which you committed into the libstdc++-v3 testsuite...
> > > 
> > > FAIL: decimal/binary-arith.cc (test for excess errors)
> > > WARNING: decimal/binary-arith.cc compilation failed to produce executable
> > <lots more failures>
> > > 
> > > Are these tests entirely glibc-centric and shouldn't they be disabled for
> > > darwin?
> > 
> > Each test contains
> > 
> >   // { dg-require-effective-target-dfp }
> > 
> > which checks that the compiler supports modes SD, DD, and TD, which
> > in turn are supported if ENABLE_DECIMAL_FLOAT is defined within the
> > compiler.  That should not be defined for darwin; I'll take a look.
> 
> I built a cross cc1plus for x86_64-apple-darwin10 and got the behavior
> I expected.  From $objdir/gcc:
> 
> elm3b149% fgrep -l ENABLE_DECIMAL_FLOAT *.h
> auto-host.h:#define ENABLE_DECIMAL_FLOAT 0
> 
> elm3b149% echo "float x __attribute__((mode(DD)));" > x.c
> elm3b149% ./cc1plus -quiet x.c
> x.c:1:33: error: unable to emulate ‘DD’
> 
> Please try that little test with your cc1plus to see if the problem
> is with your compiler not rejecting DD mode, or with the test
> framework not handling it correctly.
> 
> Janis

Janis,
   I find that ENABLE_DECIMAL_FLOAT is set to 0 on x86_64-apple-darwin10...

[MacPro:gcc45-4.4.999-20091005/darwin_objdir/gcc] root# grep ENABLE_DECIMAL_FLOAT auto-host.h
#define ENABLE_DECIMAL_FLOAT 0

and the test code fails to compile...

[MacPro:gcc45-4.4.999-20091005/darwin_objdir/gcc] root# echo "float x __attribute__((mode(DD)));" > x.c
[MacPro:gcc45-4.4.999-20091005/darwin_objdir/gcc] root# ./cc1plus -quiet x.c
x.c:1:33: error: unable to emulate ‘DD’

However, the testsuite failures still occurs as follows...

Executing on host: /sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/./gcc/g++ -shared-libgcc -B/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/./gcc -nostdinc++ -L/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/src -L/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/src/.libs -B/sw/lib/gcc4.5/x86_64-apple-darwin10.0.0/bin/ -B/sw/lib/gcc4.5/x86_64-apple-darwin10.0.0/lib/ -isystem /sw/lib/gcc4.5/x86_64-apple-darwin10.0.0/include -isystem /sw/lib/gcc4.5/x86_64-apple-darwin10.0.0/sys-include -g -O2 -D_GLIBCXX_ASSERT -fmessage-length=0 -ffunction-sections -fdata-sections -g -O2 -g -O2 -DLOCALEDIR="." -nostdinc++ -I/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/x86_64-apple-darwin10.0.0 -I/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include -I/sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/libsupc++ -I/sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/include/backward -I/sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/testsuite/util /sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/testsuite/decimal/binary-arith.cc    -include bits/stdc++.h ./libtestc++.a -L/sw/lib -liconv  -lm   -o ./binary-arith.exe    (timeout = 600)
In file included from /sw/src/fink.build/gcc45-4.4.999-20091005/gcc-4.5-20091005/libstdc++-v3/testsuite/decimal/binary-arith.cc:22:0:
/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/decimal/decimal:39:2: error: #error This file requires compiler and library support for ISO/IEC TR 24733 that is currently not available.
/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/decimal/decimal:228:56: error: unable to emulate 'SD'
/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/decimal/decimal:249:5: error: 'std::decimal::decimal32::decimal32(std::decimal::decimal32::__decfloat32)' cannot be overloaded
/sw/src/fink.build/gcc45-4.4.999-20091005/darwin_objdir/x86_64-apple-darwin10.0.0/libstdc++-v3/include/decimal/decimal:236:14: error: with 'std::decimal::decimal32::decimal32(float)'

etc...for about a hundred errors. Doesn't this imply that the dejagnu test harness isn't properly recognizing the absence of
the decimal support?
                 Jack

Re: new libstdc++-v3 decimal failures

[Janis Johnson]

On Tue, 2009-10-06 at 09:10 -0700, Janis Johnson wrote:
> On Tue, 2009-10-06 at 09:04 -0400, Jack Howarth wrote:
> > Janis,
> >    We are seeing failures of the new decimal testcases on x86_64-apple-darwin10
> > which you committed into the libstdc++-v3 testsuite...
> > 
> > FAIL: decimal/binary-arith.cc (test for excess errors)
> > WARNING: decimal/binary-arith.cc compilation failed to produce executable
> <lots more failures>
> > 
> > Are these tests entirely glibc-centric and shouldn't they be disabled for
> > darwin?
> 
> Each test contains
> 
>   // { dg-require-effective-target-dfp }
> 
> which checks that the compiler supports modes SD, DD, and TD, which
> in turn are supported if ENABLE_DECIMAL_FLOAT is defined within the
> compiler.  That should not be defined for darwin; I'll take a look.

I built a cross cc1plus for x86_64-apple-darwin10 and got the behavior
I expected.  From $objdir/gcc:

elm3b149% fgrep -l ENABLE_DECIMAL_FLOAT *.h
auto-host.h:#define ENABLE_DECIMAL_FLOAT 0

elm3b149% echo "float x __attribute__((mode(DD)));" > x.c
elm3b149% ./cc1plus -quiet x.c
x.c:1:33: error: unable to emulate ‘DD’

Please try that little test with your cc1plus to see if the problem
is with your compiler not rejecting DD mode, or with the test
framework not handling it correctly.

Janis

Re: new libstdc++-v3 decimal failures

[Janis Johnson]

On Tue, 2009-10-06 at 09:04 -0400, Jack Howarth wrote:
> Janis,
>    We are seeing failures of the new decimal testcases on x86_64-apple-darwin10
> which you committed into the libstdc++-v3 testsuite...
> 
> FAIL: decimal/binary-arith.cc (test for excess errors)
> WARNING: decimal/binary-arith.cc compilation failed to produce executable
<lots more failures>
> 
> Are these tests entirely glibc-centric and shouldn't they be disabled for
> darwin?

Each test contains

  // { dg-require-effective-target-dfp }

which checks that the compiler supports modes SD, DD, and TD, which
in turn are supported if ENABLE_DECIMAL_FLOAT is defined within the
compiler.  That should not be defined for darwin; I'll take a look.

Janis

new libstdc++-v3 decimal failures

[Jack Howarth]

Janis,
   We are seeing failures of the new decimal testcases on x86_64-apple-darwin10
which you committed into the libstdc++-v3 testsuite...

FAIL: decimal/binary-arith.cc (test for excess errors)
WARNING: decimal/binary-arith.cc compilation failed to produce executable
FAIL: decimal/cast_neg.cc (test for excess errors)
FAIL: decimal/comparison.cc (test for excess errors)
WARNING: decimal/comparison.cc compilation failed to produce executable
FAIL: decimal/compound-assignment-memfunc.cc (test for excess errors)
WARNING: decimal/compound-assignment-memfunc.cc compilation failed to produce executable
FAIL: decimal/compound-assignment.cc (test for excess errors)
WARNING: decimal/compound-assignment.cc compilation failed to produce executable
FAIL: decimal/conversion-from-float.cc (test for excess errors)
WARNING: decimal/conversion-from-float.cc compilation failed to produce executable
FAIL: decimal/conversion-from-integral.cc (test for excess errors)
WARNING: decimal/conversion-from-integral.cc compilation failed to produce executable
FAIL: decimal/conversion-to-generic-float.cc (test for excess errors)
WARNING: decimal/conversion-to-generic-float.cc compilation failed to produce executable
FAIL: decimal/conversion-to-integral.cc (test for excess errors)
WARNING: decimal/conversion-to-integral.cc compilation failed to produce executable
FAIL: decimal/ctor.cc (test for excess errors)
WARNING: decimal/ctor.cc compilation failed to produce executable
FAIL: decimal/incdec-memfunc.cc (test for excess errors)
WARNING: decimal/incdec-memfunc.cc compilation failed to produce executable
FAIL: decimal/incdec.cc (test for excess errors)
WARNING: decimal/incdec.cc compilation failed to produce executable
FAIL: decimal/make-decimal.cc (test for excess errors)
WARNING: decimal/make-decimal.cc compilation failed to produce executable
FAIL: decimal/unary-arith.cc (test for excess errors)
WARNING: decimal/unary-arith.cc compilation failed to produce executable

Are these tests entirely glibc-centric and shouldn't they be disabled for
darwin?
                 Jack