From: Jeffrey A Law <law@cygnus.com>
To: Ian Lance Taylor <ian@cygnus.com>
Cc: pcg@goof.com, egcs@cygnus.com
Subject: Re: i386.c warnings cleanup
Date: Tue, 10 Feb 1998 00:53:00 -0000 [thread overview]
Message-ID: <13176.887083804@hurl.cygnus.com> (raw)
In-Reply-To: <199802100349.WAA07459@subrogation.cygnus.com>
In message < 199802100349.WAA07459@subrogation.cygnus.com >you write:
> Date: Tue, 10 Feb 1998 04:15:43 +0100
> From: Marc Lehmann <pcg@goof.com>
>
> +extern void error PVPROTO((char *s, ...));
> +extern int atoi PROTO((char *));
> +extern void bcopy PROTO((void *, void *, int n));
> +extern void set_float_handler PROTO((jmp_buf));
> +extern void free PROTO((void *));
>
> It's safest to never declare system functions, but to instead get the
> declarations from system header files. That's because on old systems
> you can't predict how the functions will be declared. For example,
> the SunOS <stdlib.h> declares free as returning int.
>
> You should instead simply include the correct header files, and trust
> them.
Agreed. And if a prototype is absolutely necessary then you
make it conditional on NEED_DECLARATION_xxxxx
jeff
next prev parent reply other threads:[~1998-02-10 0:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-02-09 19:27 Marc Lehmann
1998-02-09 19:49 ` Ian Lance Taylor
1998-02-10 0:53 ` Jeffrey A Law [this message]
1998-02-10 3:34 ` Robert Lipe
1998-02-11 0:47 ` Marc Lehmann
1998-02-12 2:36 ` Jeffrey A Law
1998-02-11 0:47 ` Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13176.887083804@hurl.cygnus.com \
--to=law@cygnus.com \
--cc=egcs@cygnus.com \
--cc=ian@cygnus.com \
--cc=pcg@goof.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).