From: Jeffrey A Law <law@cygnus.com>
To: mark@markmitchell.com
Cc: egcs@cygnus.com, egcs-patches@cygnus.com
Subject: Re: Alias code
Date: Mon, 29 Jun 1998 22:34:00 -0000 [thread overview]
Message-ID: <13462.899137606@hurl.cygnus.com> (raw)
In-Reply-To: <199806291545.IAA01665@smtp.earthlink.net>
In message < 199806291545.IAA01665@smtp.earthlink.net >you write:
> Right. I thought of this problem, and had meant to do something about
> it, but forgot. I apologize profusely for wasting your time.
Don't worry about it. The mad ramblings of a sleep deprived man :-)
I was determined to pin the problem on something from the merge and it
didn't even occur to me that it could have been the alias code -- especially
since I wasn't using -fstrict-aliasing.
One more thought -- we might want to check flag_strict_aliasing in
DIFFERENT_ALIAS_SETS_P. It shouldn't matter after your patch, but
I don't think it hurts in any significant way.
> I think the only thing we can do is modify gen_rtx to special case
> MEM. BTW, configuring with --enable-checking and compiling with
> -fno-strict-aliasing might help; the type-based aliasing code will
> then abort if there's ever a MEM that is *not* in alias set zero.
Right. It probably would have caught this case (unless it changed
memory layout enough -- though it's likely we would have triggered a
fault somewhere else.
Once I had zero'd in on the alias code it was pretty trivial to find
out what had gone wrong :-)
> How about this patch?
>
> --
> Mark Mitchell mark@markmitchell.com
> Mark Mitchell Consulting http://www.markmitchell.com
>
> Mon Jun 29 08:45:08 1998 Mark Mitchell <mark@markmitchell.com>
>
> * rtl.h: Update comment about special gen_rtx variants.
> * emit-rtl.c (gen_rtx): Handle MEMs using gen_rtx_MEM.
Looks good. Presumably we've defined gen_rtx (MEM) and gen_rtx_MEM
as explicitly unable to set the alias set. That has to be done on
the return value from those functions. Right?
Jeff
next prev parent reply other threads:[~1998-06-29 22:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-06-29 3:22 Jeffrey A Law
1998-06-29 11:08 ` Mark Mitchell
1998-06-29 22:34 ` Jeffrey A Law [this message]
1998-06-29 11:08 ` Mark Mitchell
1998-06-29 19:43 ` Jeffrey A Law
1998-06-29 14:05 ` Franz Sirl
1998-06-29 19:43 Michael Meissner
[not found] <199806291730.KAA16121@cygnus.com>
1998-06-29 20:41 ` Jeffrey A Law
1998-06-30 4:50 ` Michael P. Hayes
1998-06-30 14:46 ` Joern Rennecke
1998-07-01 0:54 ` Michael P. Hayes
1998-06-29 22:34 Franz Sirl
1998-06-30 11:53 ` David Edelsohn
1998-06-30 19:49 Mike Stump
1998-07-01 0:54 ` Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13462.899137606@hurl.cygnus.com \
--to=law@cygnus.com \
--cc=egcs-patches@cygnus.com \
--cc=egcs@cygnus.com \
--cc=mark@markmitchell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).