Re: [PATCH] for latest libg++ build failures, and some warning patches

Re: [PATCH] for latest libg++ build failures, and some warning patches

[Manfred Hollstein]

On Sat, 12 December 1998, 12:20:27, nix@esperi.demon.co.uk wrote:

 > [Cc:ed to egcs-testresults as this is only likely to affect those
 >  running `make check' over libg++]
 [Redirected to "egcs"]
 > 
 > These are all for libg++/etc/ATD-examples/, because once I'd fixed the
 > implicit int-related errors, there seemed no point to not going on and
 > fixing the warnings. (It's not as though fixing the warnings was
 > exactly arduous ;) )
 > 
 > (This time I've remembered a changelog entry, too. Sorry about last
 > time, it slipped my mind.)
 > 
 > 1998-12-12  Nix  <nix@esperi.demon.co.uk>
 > 
 > 	* ADT-examples/Patmain.cc (main): Do not rely on implicit int.
 > 	* ADT-examples/genPatkey.cc (main): Likewise.
 > 	* ADT-examples/generic-q.cc (main): Likewise.
 > 	* ADT-examples/keyhash.cc (main): Likewise, and change to void form.
 > 	* ADT-examples/tsortinp.cc (main): Likewise, and remove name of first
 > 	  parameter to suppress unuse warning.
 > 	* ADT-examples/tsort.cc (main): Likewise.
 > 	  (Vertex_Node::Vertex_Node,Assoc_Iter::Assoc_Iter): Order initializer
 > 	  as in field declaration.
 > 	* ADT-examples/kmp.cc (kmp::kmp): Order initializer as in field
 > 	  declaration.
 > 

Cool, thanks for your contribution.  I'll put it into the next snapshot.

manfred

Re: [PATCH] for latest libg++ build failures, and some warning patches

[Manfred Hollstein]

On Sat, 12 December 1998, 15:36:03, nix@esperi.demon.co.uk wrote:

 > Manfred Hollstein writes:
 > > Cool, thanks for your contribution.  I'll put it into the next snapshot.
 > 
 > And, you'll never guess what, it still doesn't build, there were more
 > of the little buggers. I've actually done a `make check' in libg++/etc 
 > this time, and that builds, so this should be all of them.

Hey, what are you doing? I've built libg++ on various systems myself!?!?!

 > 
 > Nice to see a g++ stamping on implicit int at last, I must say.

That's a very big improvement, indeed.

 > 
 > 1998-12-12  Nix  <nix@esperi.demon.co.uk>
 > 
 > 	* benchmarks/dhrystone.cc(Proc0): Remove unused variable.
 > 	  (main): Do not rely on implicit int.
 > 	* PlotFile3D/tPlotFile3D.cc(main): Likewise.
 > 	* trie-gen/compact.cc(CompactMatrix::CompactMatrix):
 > 	  Order initializer as in field declaration.
 > 
 > *** libg++/etc/benchmarks/dhrystone.cc.orig	Sat Dec 12 15:17:04 1998
 > --- libg++/etc/benchmarks/dhrystone.cc	Sat Dec 12 15:20:49 1998
 > ***************
 > *** 416,421 ****
 > --- 416,422 ----
 >   
 >   /*end - dl */
 >   
 > + int
 >   main()
 >   {
 >   	Proc0();
 > ***************
 > *** 439,445 ****
 >   	OneToFifty		IntLoc1;
 >   	REG OneToFifty		IntLoc2;
 >   	OneToFifty		IntLoc3;
 > - 	REG char		CharLoc;
 >   	REG char		CharIndex;
 >   	Enumeration	 	EnumLoc;
 >   	String30		String1Loc;
 > --- 440,445 ----
 > *** libg++/etc/PlotFile3D/tPlotFile3D.cc.orig	Sat Dec 12 15:22:07 1998
 > --- libg++/etc/PlotFile3D/tPlotFile3D.cc	Sat Dec 12 15:22:50 1998
 > ***************
 > *** 1,4 ****
 > --- 1,5 ----
 >   #include <PlotFile3D.h>
 > + int
 >   main()
 >   {
 >     PlotFile3D foo("test.pl");
 > *** libg++/etc/trie-gen/compact.cc.orig	Sat Dec 12 15:24:13 1998
 > --- libg++/etc/trie-gen/compact.cc	Sat Dec 12 15:26:49 1998
 > ***************
 > *** 57,63 ****
 >      handle matrices with fixed, but arbitrary-sized columns and rows. */
 >   
 >   Compact_Matrix::Compact_Matrix (ITEM_TYPE *mat, int rows, int cols):
 > !      matrix (mat), max_rows (rows), total_cols (cols), current_rows (rows)
 >   {
 >     init (rows);
 >   
 > --- 57,63 ----
 >      handle matrices with fixed, but arbitrary-sized columns and rows. */
 >   
 >   Compact_Matrix::Compact_Matrix (ITEM_TYPE *mat, int rows, int cols):
 > !      total_cols (cols), current_rows (rows), max_rows (rows), matrix (mat)
 >   {
 >     init (rows);
 >   
 > 
 > 
 > -- 
 > `Anyone who says you can have a lot of widely dispersed people hack
 >  away on a complicated piece of code and avoid total anarchy has never
 >  managed a software project.' - Andy Tanenbaum in 1992 on comp.os.minix
 > 

Re: [PATCH] for latest libg++ build failures, and some warning patches

[Nix]

Manfred Hollstein writes:
> Cool, thanks for your contribution.  I'll put it into the next snapshot.

And, you'll never guess what, it still doesn't build, there were more
of the little buggers. I've actually done a `make check' in libg++/etc 
this time, and that builds, so this should be all of them.

Nice to see a g++ stamping on implicit int at last, I must say.

1998-12-12  Nix  <nix@esperi.demon.co.uk>

	* benchmarks/dhrystone.cc(Proc0): Remove unused variable.
	  (main): Do not rely on implicit int.
	* PlotFile3D/tPlotFile3D.cc(main): Likewise.
	* trie-gen/compact.cc(CompactMatrix::CompactMatrix):
	  Order initializer as in field declaration.

*** libg++/etc/benchmarks/dhrystone.cc.orig	Sat Dec 12 15:17:04 1998
--- libg++/etc/benchmarks/dhrystone.cc	Sat Dec 12 15:20:49 1998
***************
*** 416,421 ****
--- 416,422 ----
  
  /*end - dl */
  
+ int
  main()
  {
  	Proc0();
***************
*** 439,445 ****
  	OneToFifty		IntLoc1;
  	REG OneToFifty		IntLoc2;
  	OneToFifty		IntLoc3;
- 	REG char		CharLoc;
  	REG char		CharIndex;
  	Enumeration	 	EnumLoc;
  	String30		String1Loc;
--- 440,445 ----
*** libg++/etc/PlotFile3D/tPlotFile3D.cc.orig	Sat Dec 12 15:22:07 1998
--- libg++/etc/PlotFile3D/tPlotFile3D.cc	Sat Dec 12 15:22:50 1998
***************
*** 1,4 ****
--- 1,5 ----
  #include <PlotFile3D.h>
+ int
  main()
  {
    PlotFile3D foo("test.pl");
*** libg++/etc/trie-gen/compact.cc.orig	Sat Dec 12 15:24:13 1998
--- libg++/etc/trie-gen/compact.cc	Sat Dec 12 15:26:49 1998
***************
*** 57,63 ****
     handle matrices with fixed, but arbitrary-sized columns and rows. */
  
  Compact_Matrix::Compact_Matrix (ITEM_TYPE *mat, int rows, int cols):
!      matrix (mat), max_rows (rows), total_cols (cols), current_rows (rows)
  {
    init (rows);
  
--- 57,63 ----
     handle matrices with fixed, but arbitrary-sized columns and rows. */
  
  Compact_Matrix::Compact_Matrix (ITEM_TYPE *mat, int rows, int cols):
!      total_cols (cols), current_rows (rows), max_rows (rows), matrix (mat)
  {
    init (rows);
  


-- 
`Anyone who says you can have a lot of widely dispersed people hack
 away on a complicated piece of code and avoid total anarchy has never
 managed a software project.' - Andy Tanenbaum in 1992 on comp.os.minix

Re: [PATCH] for latest libg++ build failures, and some warning patches

[Nix]

Manfred Hollstein writes:
> On Sat, 12 December 1998, 15:36:03, nix@esperi.demon.co.uk wrote:
> 
>  > Manfred Hollstein writes:
>  > > Cool, thanks for your contribution.  I'll put it into the next snapshot.
>  > 
>  > And, you'll never guess what, it still doesn't build, there were more
>  > of the little buggers. I've actually done a `make check' in libg++/etc 
>  > this time, and that builds, so this should be all of them.
> 
> Hey, what are you doing? I've built libg++ on various systems myself!?!?!

Fatal: Brain underflow: Misphrased.

s/it still doesn't build/it still doesn't `make check'

-- 
`Anyone who says you can have a lot of widely dispersed people hack
 away on a complicated piece of code and avoid total anarchy has never
 managed a software project.' - Andy Tanenbaum in 1992 on comp.os.minix

Re: [PATCH] for latest libg++ build failures, and some warning patches

[Manfred Hollstein]

On Sat, 12 December 1998, 21:00:07, nix@esperi.demon.co.uk wrote:

 > Manfred Hollstein writes:
 > > On Sat, 12 December 1998, 15:36:03, nix@esperi.demon.co.uk wrote:
 > > 
 > >  > Manfred Hollstein writes:
 > >  > > Cool, thanks for your contribution.  I'll put it into the next snapshot.
 > >  > 
 > >  > And, you'll never guess what, it still doesn't build, there were more
 > >  > of the little buggers. I've actually done a `make check' in libg++/etc 
 > >  > this time, and that builds, so this should be all of them.
 > > 
 > > Hey, what are you doing? I've built libg++ on various systems myself!?!?!
 > 
 > Fatal: Brain underflow: Misphrased.
 > 
 > s/it still doesn't build/it still doesn't `make check'

OK, I was unclear, too; but, AFAIR you're building/checking on i586-pc-linux-gnu,
right? This is actually the same configuration that I built/checked on recently
without any problems?!?!?

manfred

 > 
 > -- 
 > `Anyone who says you can have a lot of widely dispersed people hack
 >  away on a complicated piece of code and avoid total anarchy has never
 >  managed a software project.' - Andy Tanenbaum in 1992 on comp.os.minix
 > 

Re: [PATCH] for latest libg++ build failures, and some warning patches

[Nix]

Manfred Hollstein writes:
>  > s/it still doesn't build/it still doesn't `make check'
> 
> OK, I was unclear, too; but, AFAIR you're building/checking on i586-pc-linux-gnu,
> right? This is actually the same configuration that I built/checked on recently
> without any problems?!?!?

The implicit int-related errors only started appearing *after* the
last snapshot; I'm using the mainline tree, last updated at 12/12/98,
15:36.

This was the first time I saw this symptom.

-- 
`Anyone who says you can have a lot of widely dispersed people hack
 away on a complicated piece of code and avoid total anarchy has never
 managed a software project.' - Andy Tanenbaum in 1992 on comp.os.minix