public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: "Eric Gallager" <egall@gwmail.gwu.edu>, "Martin Liška" <mliska@suse.cz>
Cc: GCC Development <gcc@gcc.gnu.org>
Subject: Re: [PATCH] Add new tests for --completion option.
Date: Fri, 29 Jun 2018 22:41:00 -0000	[thread overview]
Message-ID: <1530295474.23999.213.camel@redhat.com> (raw)
In-Reply-To: <CAMfHzOvmu9cC_9Q1QweAyfFxP9jq_S0AkrYGW40bLD6Sy+9Yyw@mail.gmail.com>

On Fri, 2018-06-29 at 13:19 -0400, Eric Gallager wrote:
> On 6/29/18, Martin Liška <mliska@suse.cz> wrote:
> > Hi.
> > 
> > I would like to add some DejaGNU tests for completion option.
> > 
> > Ready for trunk?
> > Martin

Presumably the point of the DejaGnu tests is:
(a) to give us some integration testing, to complement the unit-tests
expressed via "selftest::" in the code
(b) in future, to allow for target-specific tests for the aspects of
completion (some target-specific options have non-standard arg-parsing, 
iirc, so might need special-casing if the completion code is to be
perfect).  Also, it allows for other DejaGnu-based filters to be used.

> So, correct me if I'm wrong, but these tests would need to be updated
> every time a new option starting like one of those is added, right? 

You're correct.

> If
> so, can you think of any ways to ease the increased maintenance
> efforts?

I think/hope Martin picked option prefixes for which the results are
relatively stable.

If it turns out to be a pain, other options can be chosen, but I guess
we can cross that bridge when we come to it.

Dave

  reply	other threads:[~2018-06-29 18:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 15:00 RFC: bash completion Martin Liška
2018-04-24 16:49 ` David Malcolm
2018-04-25 13:13   ` Martin Liška
2018-04-25 13:53   ` Martin Liška
2018-06-29 15:04 ` [PATCH] Add new tests for --completion option Martin Liška
2018-06-29 17:19   ` Jeff Law
2018-06-29 18:04   ` Eric Gallager
2018-06-29 22:41     ` David Malcolm [this message]
2018-07-02  9:52       ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530295474.23999.213.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=egall@gwmail.gwu.edu \
    --cc=gcc@gcc.gnu.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).