public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@cygnus.com>
To: Richard Henderson <rth@cygnus.com>
Cc: Jim Wilson <wilson@cygnus.com>, egcs@cygnus.com
Subject: Re: alpha failure on 920810-1
Date: Fri, 08 May 1998 16:08:00 -0000	[thread overview]
Message-ID: <16568.894658694@hurl.cygnus.com> (raw)
In-Reply-To: <19980430173828.15223@dot.cygnus.com>

  In message < 19980430173828.15223@dot.cygnus.com >you write:
  > On Wed, Apr 29, 1998 at 10:57:53PM -0700, I wrote:
  > > In conversation with Jim today, we decided that 
  > > 
  > >          (set (reg:DF 1) (eq:DF (reg:DF 2) (reg:DF 3)))
  > >          (set (reg:DF 4)
  > >            (if_then_else:DF (eq:CC (reg:DF 1) (const_int 0))
  > >              (reg:DF 5) (reg:DF 4)))
  > > 
  > > is a reasonable compromise.  It turns out that combine already knows
  > > that it can't do anything with CCmode compares, and with my previous
  > > patch modified just a tad, that takes care of loop, jump, and cse.
  > > 
  > > I've bootstrapped succesfully with these changes, and am currently
  > > running Spec95.  Patches will follow once no regressions are shown.
  > 
  > Here they are, as promised.  Ok to apply?
  > 
  > 
  > r~
  > 
  > 
  > 
  > Thu Apr 30 17:27:47 1998  Richard Henderson  <rth@cygnus.com>
  > 
  > 	* loop.c (get_condition): Don't combine when either compare is MODE_CC.
  > 	* machmode.h (COMPLEX_MODE_P): New macro.
  > 	* alpha.c (alpha_emit_conditional_branch): New function.  Taken from
  > 	the body of beq, additionally set the mode of the branch to CCmode for
  > 	FP compares and not fast_math.  
  > 	(alpha_emit_conditional_move): Always use a compare insn for FP
  > 	when not fast_math, as well as setting CCmode on the cmov.
  > 	* alpha.md (beq, bne, blt, et al): Call alpha_emit_conditional_branch.
Seems pretty reasonable to me if Jim doesn't have objections.

I note that your patch doesn't actually use COMPLEX_MODE_P, but I do
think we ought to have it to be consistent with the other *_MODE_P
tests.

jeff

  reply	other threads:[~1998-05-08 16:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-04-27  1:41 Richard Henderson
1998-04-27  8:47 ` Joern Rennecke
1998-04-27 13:59   ` Richard Henderson
1998-04-28 22:14 ` Jim Wilson
1998-04-29  2:20   ` Richard Henderson
1998-04-29 12:27     ` Jim Wilson
1998-04-29 16:08   ` Joern Rennecke
1998-04-29 22:57     ` Richard Henderson
1998-04-30 10:25       ` Joern Rennecke
1998-04-30 13:20         ` Richard Henderson
1998-04-30 22:29       ` Richard Henderson
1998-05-08 16:08         ` Jeffrey A Law [this message]
1998-05-09  2:05           ` Richard Henderson
1998-05-06 23:49 ` Jeffrey A Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16568.894658694@hurl.cygnus.com \
    --to=law@cygnus.com \
    --cc=egcs@cygnus.com \
    --cc=rth@cygnus.com \
    --cc=wilson@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).