Re: egcs-980315, gen*.c system.h and fatal() using stdarg/varargs

[Jeffrey A Law <law@cygnus.com>]

  In message < 199803200208.VAA11947@caip.rutgers.edu >you write:
  > 	Here is my patch to add system.h to gen*.c.  It also fixes the
  > static function `fatal' to use real variable argument parameter lists.
  > 
  > 	Is so doing, I uncovered some format specifier problems in
  > genattrtab.c:
  > 
  >  > ./genattrtab.c:979: warning: char format, rtx_def arg (arg 2)
  >  > ./genattrtab.c:984: warning: char format, rtx_def arg (arg 2)
  >  > ./genattrtab.c:1001: warning: char format, rtx_def arg (arg 2)
  >  > ./genattrtab.c:1012: warning: char format, rtx_def arg (arg 2)
  >  > ./genattrtab.c:1012: warning: char format, rtx_def arg (arg 3)
  > 
  > 	All of these cases appear to be using a %s to print a XEXP(rtx,N).
  > Should these instead be changed to %s and XSTR(rtx,N) ?
Hard to be sure since the line #s do not match what's currently in
the sources.

I see 5 cases in "check_attr_test" which appear to fit the description
you've given.  Those should be using XSTR, not XINT as you suspected.

  > 	One other thing, I defined a PRINTF_ATTRIBUTE macro in
  > system.h along the lines of a similar trick in cccp.c.  However I'm
  > not sure that system.h is the right place for this.
It's as good a place as any.

  > 	I envision system.h as handling system header files, functions,
  > macros and related issues.  It seems like __attribute__, being a
  > compiler characteristic, is something for which gansidecl.h is to be
  > used for.  (Also along these lines, the bcopy/index stuff should be
  > removed from gansidecl.h now that system.h handles that.  But that's for
  > another day.)
That would be fine too.

I don't have a particular preference for where this would belong.

For the "fatal" problem -- I don't think you can rely on having
vfprintf.  You have to check for it.  If you don't have it, you'll
probably have to punt back to extracting the args as ints and
passing them to fprintf.


I would recommend checking in the changes *without* the fatal change;
then re-submit the changes for just fatal as a separate patch.

jeff