From: H.J. Lu <hjl@gnu.org>
To: law@cygnus.com
Cc: zing@cygnus.com, drepper@cygnus.com (Ulrich Drepper)
Subject: Re: Can we have egcs 1.0.3 please?
Date: Sun, 26 Apr 1998 12:45:00 -0000 [thread overview]
Message-ID: <16994.947491887.0@NO-ID-FOUND.mhonarc.org> (raw)
In-Reply-To: <2107.892965241@hurl.cygnus.com>
>
>
> In message <m0yQNZt-00058vC@ocean.lucon.org>you write:
> > There is a bad typo in libio. I have sent a patch twice.
> I asked Ulrich to take a look at the libio patch not too long
> ago. I haven't heard back from him yet.
>
> I'd really like everything going into the 1.0.3 tree to have
> been reviewed by at least one person other than the author.
>
> Maybe if you explained what is wrong and how your patch fixes
> the problem, someone could try to evaluate the patch. Instead
> you just said "it's a typo" with zero explanation about what's
> going on.
See
http://www.cygnus.com/ml/egcs-bugs/1998-Apr/0028.html
http://www.cygnus.com/ml/egcs-bugs/1998-Apr/0046.html
I am enclosing my original patch with the typo in it here. As you can
see, I changed "count" to "_gcount" in "if" without removing count.
--
H.J. Lu (hjl@gnu.org)
---
--- /home/work/misc/gnu/import/egcs/libio/isgetline.cc Thu Aug 21 15:58:19 1997
+++ isgetline.cc Mon Feb 16 10:48:27 1998
@@ -67,8 +68,9 @@
if (ipfx1())
{
streambuf *sbuf = rdbuf();
- long count = _IO_getline(sbuf, buf, len - 1, delim, -1);
- if (count == 0 && sbuf->sgetc() == EOF)
+ int ch;
+ long count = _IO_getline_info(sbuf, buf, len - 1, delim, -1, &ch);
+ if (_gcount == 0 && ch == EOF)
set(ios::failbit|ios::eofbit);
else
_gcount = count;
next parent reply other threads:[~1998-04-26 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2107.892965241@hurl.cygnus.com>
1998-04-26 12:45 ` H.J. Lu [this message]
[not found] <199804182235.PAA27290@rtl.cygnus.com>
1998-04-18 22:14 ` Jeffrey A Law
1998-04-20 12:05 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16994.947491887.0@NO-ID-FOUND.mhonarc.org \
--to=hjl@gnu.org \
--cc=drepper@cygnus.com \
--cc=law@cygnus.com \
--cc=zing@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).