public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@cygnus.com>
To: Marc Lehmann <pcg@goof.com>
Cc: egcs@cygnus.com
Subject: Re: i386.c warnings cleanup
Date: Wed, 11 Feb 1998 00:47:00 -0000	[thread overview]
Message-ID: <17774.887186015@hurl.cygnus.com> (raw)
In-Reply-To: <19980210041543.12242@cerebro.laendle>

  In message < 19980210041543.12242@cerebro.laendle >you write:
  > comments appreciated ;)
As other folks noted, we're better off including the appropriate
files instead of declaring things like error, bcopy, free, etc.

When declarations are absolutely needed they should be wrapped
inside autoconf #ifdefs.

jfc made some fixes to the formatting strings in i386.md, so I
didn't install that part of your patch.  If we still need the
format change after both of your patches it can be resubmitted :-)

I installed the rest of the changes.  Thanks!

jeff

      parent reply	other threads:[~1998-02-11  0:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-02-09 19:27 Marc Lehmann
1998-02-09 19:49 ` Ian Lance Taylor
1998-02-10  0:53   ` Jeffrey A Law
1998-02-10  3:34 ` Robert Lipe
1998-02-11  0:47   ` Marc Lehmann
1998-02-12  2:36     ` Jeffrey A Law
1998-02-11  0:47 ` Jeffrey A Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17774.887186015@hurl.cygnus.com \
    --to=law@cygnus.com \
    --cc=egcs@cygnus.com \
    --cc=pcg@goof.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).