From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10241 invoked by alias); 22 Apr 2002 14:38:31 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 10190 invoked from network); 22 Apr 2002 14:38:26 -0000 Received: from unknown (HELO gandalf.codesourcery.com) (66.60.148.227) by sources.redhat.com with SMTP; 22 Apr 2002 14:38:26 -0000 Received: from gandalf.codesourcery.com (localhost.localdomain [127.0.0.1]) by gandalf.codesourcery.com (8.11.6/8.11.6) with ESMTP id g3MEYHL14315; Mon, 22 Apr 2002 07:34:17 -0700 Date: Mon, 22 Apr 2002 07:48:00 -0000 From: Mark Mitchell To: Richard Henderson cc: Toon Moene , John David Anglin , "gcc@gcc.gnu.org" Subject: Re: GCC 3.1 Prerelease Message-ID: <17920000.1019486056@gandalf.codesourcery.com> In-Reply-To: <20020422000701.B31660@redhat.com> References: <200204210308.g3L38jAi022753@hiauly1.hia.nrc.ca> <3CC2B4BC.C1710C88@moene.indiv.nluug.nl> <2680000.1019414667@gandalf.codesourcery.com> <20020422000701.B31660@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-SW-Source: 2002-04/txt/msg01087.txt.bz2 --On Monday, April 22, 2002 12:07:01 AM -0700 Richard Henderson wrote: > On Sun, Apr 21, 2002 at 11:44:27AM -0700, Mark Mitchell wrote: >> + offset = (SUBREG_BYTE (x) >> + - (GET_MODE_SIZE (promoted_mode) >> + - GET_MODE_SIZE (GET_MODE (SUBREG_REG (x))))); > > Surely this adjustment should be big-endian only. Indeed. Also, there is this oddity in fixup_var_refs_1: if (GET_CODE (fixeddest) == SUBREG) { fixeddest = fixup_memory_subreg (fixeddest, insn, 0); promoted_mode = GET_MODE (fixeddest); } This makes no sense since promoted_mode is supposed to be the property of the thing being replaced and that's not changing. I fixed that, too; only the new temporary register needs the mode of fixeddest. I'll commit a modified version of the patch that corrects these two issues after one more test cycle on my local box. Thanks, -- Mark Mitchell mark@codesourcery.com CodeSourcery, LLC http://www.codesourcery.com