public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* Query use of HAVE_xxx
@ 1998-04-25 13:27 grahams
  1998-04-25 21:42 ` Jeffrey A Law
  0 siblings, 1 reply; 2+ messages in thread
From: grahams @ 1998-04-25 13:27 UTC (permalink / raw)
  To: egcs

Hi

I have noticed a potential problem with the use of the HAVE_xxx macros
defined in "insn-config.h" which is generated automatically from the   
machine
description files by genconfig.

I have noticed than gcc/jump.c has code conditionally compiled dependent
on the definition of the HAVE_cc0 macro which is defined in insn-config.h   

if the machine description supports CC0.

The problem is jump.c does not include insn-config.h either directly or
indirectly and thus will never see any definition of HAVE_cc0 that may
be in "insn-config.h"

The above example is almost definately not the only instanace where a
HAVE_xxx macro is tested, but insn-config.h has not been included.

Does anybody have any comments?

Graham


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Query use of HAVE_xxx
  1998-04-25 13:27 Query use of HAVE_xxx grahams
@ 1998-04-25 21:42 ` Jeffrey A Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeffrey A Law @ 1998-04-25 21:42 UTC (permalink / raw)
  To: grahams; +Cc: egcs

  In message < 199804252021.UAA00053@iron.rcp.co.uk >you write:
  > The problem is jump.c does not include insn-config.h either directly or
  > indirectly and thus will never see any definition of HAVE_cc0 that may
  > be in "insn-config.h"
?!?

Line 60 in the current jump.c sources:
#include "insn-config.h"

jeff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1998-04-25 21:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-04-25 13:27 Query use of HAVE_xxx grahams
1998-04-25 21:42 ` Jeffrey A Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).