From: Jeffrey A Law <law@cygnus.com>
To: drepper@cygnus.com (Ulrich Drepper)
Cc: egcs@cygnus.com
Subject: Re: x*alloc optimizations
Date: Mon, 18 May 1998 22:49:00 -0000 [thread overview]
Message-ID: <18727.895553279@hurl.cygnus.com> (raw)
In-Reply-To: <r2af8fzfwu.fsf@happy.cygnus.com>
In message < r2af8fzfwu.fsf@happy.cygnus.com >you write:
> law@cygnus.com (Jeffrey A Law) writes:
>
> > I quickly scanned your patch for any problems this creates, but didn't
> > find any. However, we should probably fix xrealloc to avoid losing if
> > a zero sized request is made.
>
> But please fix this system dependent. I.e., add a configure test for
> this non-ISO C behaviour and don't let normal systems do the same work
> twice (since their realloc implementation again checks for NULL).
The amount of time saved by this optimization is likely to be so
small that it's dwarfed by the time to write an autoconf test make
sure it does the right thing, and get it checked in. :-)
IMHO, it's not worth the effort.
jeff
next prev parent reply other threads:[~1998-05-18 22:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-05-16 22:35 Richard Henderson
1998-05-18 2:09 ` Jeffrey A Law
[not found] ` <25274.895468839.cygnus.egcs@hurl.cygnus.com>
1998-05-18 9:58 ` Ulrich Drepper
1998-05-18 22:49 ` Jeffrey A Law [this message]
1998-05-20 8:42 ` Jim Meyering
1998-05-18 18:06 Michael Meissner
1998-05-20 7:09 ` Jim Meyering
1998-05-20 12:48 Michael Meissner
1998-05-20 19:03 ` Ulrich Drepper
1998-05-20 19:03 Michael Meissner
1998-05-20 19:03 ` Ulrich Drepper
1998-05-21 0:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18727.895553279@hurl.cygnus.com \
--to=law@cygnus.com \
--cc=drepper@cygnus.com \
--cc=egcs@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).