public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@hurl.cygnus.com>
To: egcs@cygnus.com
Subject: Re: A prototype patch for tree.h/tree.def/calls.c
Date: Tue, 19 Aug 1997 16:06:35 -0000	[thread overview]
Message-ID: <m0x0q2O-0004ecC@ocean.lucon.org> (raw)
Message-ID: <19970819160635.szPFDEfw4Yt9rl2tvTZ84rI9Di0m_t0LAQHt4Sr7VwQ@z> (raw)
In-Reply-To: A prototype patch for tree.h/tree.def/calls.c

  In message <m0x0opG-0004edC@ocean.lucon.org>you write:
  > I have some problem s with my emails for the past few days. I may
  > have lost some. I only remember your comments on BUFSIZ being a macro,
  > which turned out ok. What else?
Relatively minor stuff.

For this pass #if 0 the prototypes for xmalloc and related funtions;
once the bulk of the prototypes are in, please submit a separate
patch to enable prototyping of xmalloc and related functions.

This should help deal with the varying prototypes and lack of
proper casts throughout the gcc sources.

Also, the prototypes are wrong, you changed an argument from a
"size_t" to "unsigned".  On some systems, they're different
sizes!



Other prototypes in rtl.h (and other locations) try to get the PROTOs
to line up in a nice column.  Can you line them up?  It will certainly
make them easier to read later.  Seems like a nit, but it really
makes stuff easier to read.


  > The reason of
  > odd rtl.def patch is the prototyping config.h may require
  > enum etx_code before rtl.h is included.
I don't understand this.

If config.h requires enum rtx_code before rtl.h is included, how
does this change help?

I would punt this issue for this round too.  We can return to it after
we've got the bulk of the other prototype stuff installed.


jeff

             reply	other threads:[~1997-08-19 16:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1997-08-19 16:06 H.J. Lu [this message]
1997-08-19 16:06 ` Jeffrey A Law
  -- strict thread matches above, loose matches on Subject: below --
1997-08-19 17:54 Some Haifa scheduler bugs Jeffrey A Law
1997-08-19 17:54 ` egcs: A new compiler project to merge the existing GCC forks Toon Moene
1997-08-19 17:54 H.J. Lu
1997-08-19 17:18 egcs: A new compiler project to merge the existing GCC forks (fwd) Joern Rennecke
1997-08-19 17:18 ` egcs: A new compiler project to merge the existing GCC forks Dave Love
1997-08-19 15:01 H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m0x0q2O-0004ecC@ocean.lucon.org \
    --to=law@hurl.cygnus.com \
    --cc=egcs@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).