From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey A Law To: egcs@cygnus.com Subject: Re: A prototype patch for tree.h/tree.def/calls.c Date: Tue, 19 Aug 1997 16:06:35 -0000 Message-ID: In-reply-to: A prototype patch for tree.h/tree.def/calls.c X-SW-Source: 1997-08/0153.html Message-ID: <19970819160635.szPFDEfw4Yt9rl2tvTZ84rI9Di0m_t0LAQHt4Sr7VwQ@z> In message you write: > I have some problem s with my emails for the past few days. I may > have lost some. I only remember your comments on BUFSIZ being a macro, > which turned out ok. What else? Relatively minor stuff. For this pass #if 0 the prototypes for xmalloc and related funtions; once the bulk of the prototypes are in, please submit a separate patch to enable prototyping of xmalloc and related functions. This should help deal with the varying prototypes and lack of proper casts throughout the gcc sources. Also, the prototypes are wrong, you changed an argument from a "size_t" to "unsigned". On some systems, they're different sizes! Other prototypes in rtl.h (and other locations) try to get the PROTOs to line up in a nice column. Can you line them up? It will certainly make them easier to read later. Seems like a nit, but it really makes stuff easier to read. > The reason of > odd rtl.def patch is the prototyping config.h may require > enum etx_code before rtl.h is included. I don't understand this. If config.h requires enum rtx_code before rtl.h is included, how does this change help? I would punt this issue for this round too. We can return to it after we've got the bulk of the other prototype stuff installed. jeff