From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeffrey A Law <law@hurl.cygnus.com>
To: egcs@cygnus.com
Subject: Re: A prototype patch for tree.h/tree.def/calls.c
Date: Tue, 19 Aug 1997 19:00:07 -0000
Message-ID: <m0x0tCN-0004edC@ocean.lucon.org>
In-reply-to: A prototype patch for tree.h/tree.def/calls.c
X-SW-Source: 1997-08/0181.html
Message-ID: <19970819190007.O14jYkRCt72pW_OSvbqnnpsEFYPqFmxxh5NZ-g2XsDs@z>

  In message <m0x0tCN-0004edC@ocean.lucon.org>you write:
  > > Please disable them for the patch.
  > 
  > It is disabled in all my patches. Please double check it.
OK.  Thank you.

  > > NO!  You simply can't change from size_t to unsigned, that's
  > > just plain wrong.
  > 
  > Please check all xmalloc definitions in egcs. Many of
  > them use unsigned.
I'm not saying they don't.  They are wrong and should be fixed,
but we can fix them later, we don't have to fix them now.

But regardless of what other parts of gcc are doing, using "unsigned"
in the prototype for xmalloc is wrong and such a change will not be
installed.

Please punt xmalloc and friends.  It can be revisited later.

The point here is to make progress.  That means punting issues
which are tricky so that we can get the bulk of your changes
installed.


  > >   * Don't mess with the enum rtx_code and enum tree_code stuff
  > >     right now.
  > 
  > Why, my change is small and working. It is very trivial
  > to back it out. When will the greatest one be found anyway?
I (and others) think that part of the patch is gross and disgusting.
It will not be installed.

  > 
  > >   * Do some minor formatting.
  > 
  > I am talking about over 5,000 lines of code. I don't feel like
  > to reformat it for something that no compilers even care. I think
  > protoptype is for compilers, not for human. But, again, feel free
  > to reformat it.
Then your code will have to wait.  Maybe you should have been in
contact with others before you wrote 5000 lines of code.

Just because egcs is being more open doesn't mean we're just going
to take whatever patch you whip up and install it.  You still have
to write good patches.

If you refuse to write good patches, then your patches will get
installed when we can get around to fixing them -- and with the
amount of other stuff going on, including a release in two weeks
fixing your patches certainly isn't at the top of my todo list.

All I can do is point out the things that need to be fixed, then
hope you (or someone) will fix them and then we can install the
patch.


Jeff