Re: A prototype patch for tree.h/tree.def/calls.c

[Jeffrey A Law <law@hurl.cygnus.com>]

  In message <m0x0r16-0004edC@ocean.lucon.org>you write:
  > > 
  > >   In message <m0x0opG-0004edC@ocean.lucon.org>you write:
  > >   > I have some problem s with my emails for the past few days. I may
  > >   > have lost some. I only remember your comments on BUFSIZ being a macro
  > ,
  > >   > which turned out ok. What else?
  > > Relatively minor stuff.
  > > 
  > > For this pass #if 0 the prototypes for xmalloc and related funtions;
  > > once the bulk of the prototypes are in, please submit a separate
  > > patch to enable prototyping of xmalloc and related functions.
  > 
  > On my machine, they are enabled.
Please disable them for the patch.

  > That is exactly the problem with size_t. How can you be
  > sure size_t is available on all systems when xmalloc ()
  > is used? many xmalloc () in gcc use unsigned. I think
  > it makes some senses.
NO!  You simply can't change from size_t to unsigned, that's
just plain wrong.

Seems to me the right way to do this is with autoconf.


  > I have spent weeks on it. I am afraid I may make some
  > stupid mistakes if I try to reformat it. After all,
  > those prototypes are mainly for compiler. Please feel
  > free to reformat it. Thanks.
Then they're not likely to go in anytime soon.  I don't have the
time to spend reformatting all your changes.

  > Here is what I have in my i386.h:
  > 
  > #define NEED_enum_rtx_code    
  > #include "rtl.def"                
  > #undef NEED_enum_rtx_code                                        
  > #define NEED_enum_machine_mode                                     
  > #include "machmode.def"               
  > #undef NEED_enum_machine_mode                       
I had a feeling you'd done something like this -- let's punt this
for now until we can come up with something better.


So, it seems to me you need to do 3 things:

  * #if0 the xmalloc and friends prototypes.
  * Don't mess with the enum rtx_code and enum tree_code stuff
    right now.
  * Do some minor formatting.

We're not talking about a lot of work that you'd need to do to
get your patches installed immediately.

Jeff