public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@hurl.cygnus.com>
To: egcs@cygnus.com
Subject: Re: Probable bug in gcc/reg-stack.c (example given)
Date: Wed, 27 Aug 1997 03:29:01 -0000	[thread overview]
Message-ID: <9708270329.AA19020@modi.xraylith.wisc.edu> (raw)
Message-ID: <19970827032901.oz_7MgawWEOyeXxiINjNeN0TTs3EvfpYdHbaXmvuw2g@z> (raw)
In-Reply-To: Probable bug in gcc/reg-stack.c (example given)

First, when looking for a set of an FP register, it seems to me
that just checking that the pattern is a (set (fp) (something))
won't work for insns like this:

(define_insn ""
  [(set (match_operand:SF 0 "nonimmediate_operand" "=f,m")
        (float_truncate:SF
         (match_operand:DF 1 "register_operand" "0,f")))
   (clobber (match_operand:SF 2 "memory_operand" "m,m"))]
  "TARGET_80387"

It seems to me you should use reg_set_p when you're looking
for a set of an FP register and for a set of the PC register.

Or, you need to iterate through each item in a PARALLEL and
do the check for (set (fp) (something))

I also think your patch will pessimize the code when it
runs into a jump table.  I think this can be easily solved
too (look in flow.c I think you can actually crib a lot of
the code from find_basic_blocks).

jeff

             reply	other threads:[~1997-08-27  3:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1997-08-27  3:29 Mumit Khan [this message]
1997-08-27  3:29 ` Jeffrey A Law
  -- strict thread matches above, loose matches on Subject: below --
1997-08-28  8:21 HAVE_STDLIB_H Craig Burley
1997-08-28  8:21 ` Here are the g++ test results Alexandre Oliva
1997-08-27 22:01 egcs release Jim Wilson
1997-08-27 22:16 ` Here are the g++ test results Jeffrey A Law
1997-08-27 21:00 djohnson
1997-08-27 20:19 A vtable thunks bug Mike Stump
1997-08-27 20:45 ` Here are the g++ test results Jeffrey A Law
1997-08-27 16:44 Joe Buck
1997-08-27  8:07 Some Linux patches Richard Henderson
1997-08-27 11:05 ` Here are the g++ test results djohnson
1997-08-27  3:29 egcs check-gcc results on mips-sgi-irix5.3 (970825 snapshot) scott snyder
1997-08-27  5:21 ` Here are the g++ test results Jeffrey A Law
1997-08-27  0:20 H.J. Lu
1997-08-26 23:42 djohnson
1997-08-26 21:22 Mumit Khan
1997-08-26  4:00 g77 configuring, docs (was Re: 970825 Snapshot Available) Craig Burley
1997-08-26  6:26 ` Here are the g++ test results Steven J. Madsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9708270329.AA19020@modi.xraylith.wisc.edu \
    --to=law@hurl.cygnus.com \
    --cc=egcs@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).