public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* glitch in gcc/invoke.texi
@ 1997-08-29  5:38 Joe Buck
  1997-08-29  6:00 ` a g++ bug in namespace code Kriang Lerdsuwanakij
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Buck @ 1997-08-29  5:38 UTC (permalink / raw)
  To: egcs

Don't forget to double those @ signs in texi docs.

*** invoke.texi.old	1997/08/29 05:32:34
--- invoke.texi	1997/08/29 05:34:24
***************
*** 2198,2204 ****
  they have helped determine the efficacy of various
  approaches to improving loop optimizations.
  
! Please let us (@code{egcs@cygnus.com and fortran@@gnu.ai.mit.edu})
  know how use of these options affects
  the performance of your production code.
  We're very interested in code that runs @emph{slower}
--- 2198,2204 ----
  they have helped determine the efficacy of various
  approaches to improving loop optimizations.
  
! Please let us (@code{egcs@@cygnus.com and fortran@@gnu.ai.mit.edu})
  know how use of these options affects
  the performance of your production code.
  We're very interested in code that runs @emph{slower}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* a g++ bug in namespace code
  1997-08-29  5:38 glitch in gcc/invoke.texi Joe Buck
@ 1997-08-29  6:00 ` Kriang Lerdsuwanakij
  0 siblings, 0 replies; 2+ messages in thread
From: Kriang Lerdsuwanakij @ 1997-08-29  6:00 UTC (permalink / raw)
  To: egcs

Hi,

I looked at namespace codes in g++ and found a bug in unnamed namespace.
The 'get_unique_name' function in 'cp/decl.c' starts replacing special
symbols with '_' at the 12th byte of the allocated buffer but the buffer
may be smaller than that.  It causes internal compiler error in my
system.  The following patch fixs the bug.

Kriang


* decl.c (get_unique_name): Prevent reading/writing outside the 
unique string when replacing chars to `_'.

--- decl.c.orig	Thu Aug 28 20:17:36 1997
+++ decl.c	Thu Aug 28 20:18:04 1997
@@ -1694,7 +1694,7 @@
   /* Don't need to pull weird characters out of global names.  */
   if (p != first_global_object_name)
     {
-      for (p = buf+11; *p; p++)
+      for (p = buf+2; *p; p++)
 	if (! ((*p >= '0' && *p <= '9')
 #ifndef NO_DOLLAR_IN_LABEL	/* this for `$'; unlikely, but... -- kr */
 	       || *p == '$'

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1997-08-29  6:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1997-08-29  5:38 glitch in gcc/invoke.texi Joe Buck
1997-08-29  6:00 ` a g++ bug in namespace code Kriang Lerdsuwanakij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).