Re: A patch for test case

Re: A patch for test case

[Richard Henderson]

>   In message you write:
>   > Without this patch, it will fail on any dynamic linker which
>   > uses global strcmp ().
> Tege comments?

Many dynamic linkers are self-contained and isolate themselves from
the surrounding environment. 

With glibc, this is not the case.  We share code between ld.so, libc.so
and libdl.so, and it is a feature that ld.so uses the symbols from the
surrounding environment so that things like overriding malloc work
correctly.

This fails, of course, when the user provides broken versions of those
functions, as this test does.  Making the symbol static removes the
broken function from the view of ld.so.


r~

Re: A patch for test case

[Jeffrey A Law]

  In message you write:
  > Without this patch, it will fail on any dynamic linker which
  > uses global strcmp ().
Tege comments?


  > -- 
  > H.J. Lu (hjl@gnu.ai.mit.edu)
  > ---
  > Index: gcc/testsuite/gcc.c-torture/execute/921007-1.c
  > ===================================================================
  > RCS file: /home/work/cvs/gnu/egcs/gcc/testsuite/gcc.c-torture/execute/92100
  > 7-1.c,v
  > retrieving revision 1.1.1.1
  > diff -u -r1.1.1.1 921007-1.c
  > --- 921007-1.c	1997/08/26 00:21:22	1.1.1.1
  > +++ 921007-1.c	1997/08/28 19:49:30
  > @@ -1,4 +1,4 @@
  > -int strcmp(){return-1;}
  > +static int strcmp(){return-1;}
  >  #define strcmp __builtin_strcmp
  >  main()
  >  {

A patch for test case

[H.J. Lu]

Without this patch, it will fail on any dynamic linker which
uses global strcmp ().

Thanks.


-- 
H.J. Lu (hjl@gnu.ai.mit.edu)
---
Index: gcc/testsuite/gcc.c-torture/execute/921007-1.c
===================================================================
RCS file: /home/work/cvs/gnu/egcs/gcc/testsuite/gcc.c-torture/execute/921007-1.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 921007-1.c
--- 921007-1.c	1997/08/26 00:21:22	1.1.1.1
+++ 921007-1.c	1997/08/28 19:49:30
@@ -1,4 +1,4 @@
-int strcmp(){return-1;}
+static int strcmp(){return-1;}
 #define strcmp __builtin_strcmp
 main()
 {