Re: testing consistency

[Joe Buck <jbuck@synopsys.com>]

I wrote:
>   > I think that I'd like to see a bit more discipline in how we do testing.
>   > Many of us are doing various tests now, but I do want to make sure that
>   > we cover the cases that users are likely to use.

Jeff writes:

> The first step in this process is to get everyone to bootstrap in the
> same manner.  Is anyone else using the rough toplevel "bootstrap"
> target I posted last week?  Comments and improvements are definitely
> welcome!

I haven't yet tried it, I have a script that configures, cd's to gcc
and does the standard 3-stage bootstrap and install, then cd's back and
does make and make install.  I'll try it out.

In the meantime, the biggest remaining lack of consistency is caused by
the g++ tests that depend on libg++ classes that are not in libstdc++.
These fail for those who haven't installed libg++ in a place where egcs
will find it and pass for others.  They need to be rewritten or dropped.

This affects seven files:

g++.brendan/crash20.C (includes Complex.h)
g++.brendan/crash30.C (String.h)
g++.brendan/crash39.C (GetOpt.h, String.h)
g++.law/operators4.C (Complex.h)
g++.mike/p658.C (bool.h)
g++.mike/p784.C (bool.h)
g++.mike/p785.C (bool.h)

I suggest the following fixes:
* For the first four tests, replace them with the preprocessor output
  using libg++, or else move them to the libg++ test suite.
* For the last three, eliminate bool.h (it has no effect on compilation
  for these tests, after the preprocessor the token stream is the same).

A trivial patch (in the directory gcc/testsuite/g++.old-deja/g++.mike --
this patch avoids changing any line numbers)

ChangeLog:
	* g++.old-deja/g++.mike/p658.C: eliminate <bool.h> use.
	* g++.old-deja/g++.mike/p784.C: Ditto.
	* g++.old-deja/g++.mike/p785.C: Ditto.

	p658.C
*** p658.C	Tue Aug 19 00:34:51 1997
--- p658-fix.C	Wed Sep 10 15:49:13 1997
***************
*** 1,7 ****
  // prms-id: 658
  
  #include <ostream.h>
! #include <bool.h>
  extern "C" void abort();
  
  /* We may not find the libg++ <bool.h>.  */
--- 1,7 ----
  // prms-id: 658
  
  #include <ostream.h>
! 
  extern "C" void abort();
  
  /* We may not find the libg++ <bool.h>.  */
*** p784.C	Tue Aug 19 00:34:52 1997
--- p784-fix.C	Wed Sep 10 15:49:44 1997
***************
*** 134,140 ****
  // $Revision: 1.1.1.1 $
  // $Date: 1997/08/19 07:34:52 $
  
! #include <bool.h>
  
  //# 25 "../../GctSymbol.h" 2
  
--- 134,140 ----
  // $Revision: 1.1.1.1 $
  // $Date: 1997/08/19 07:34:52 $
  
! 
  
  //# 25 "../../GctSymbol.h" 2
  
*** p785.C	Tue Aug 19 00:34:52 1997
--- p785-fix.C	Wed Sep 10 15:51:19 1997
***************
*** 3246,3252 ****
  // $Revision: 1.1.1.1 $
  // $Date: 1997/08/19 07:34:52 $
  
! #include <bool.h>
  
  //# 25 "../../../../mips/include/Gct/Reference/GctReferenceCount.h" 2
  
--- 3246,3252 ----
  // $Revision: 1.1.1.1 $
  // $Date: 1997/08/19 07:34:52 $
  
! 
  
  //# 25 "../../../../mips/include/Gct/Reference/GctReferenceCount.h" 2