From mboxrd@z Thu Jan 1 00:00:00 1970 From: Torbjorn Granlund To: "David S. Miller" Cc: egcs@cygnus.com Subject: Re: This was fun to track down Date: Tue, 23 Sep 1997 13:57:00 -0000 Message-id: <199709232053.WAA03509@squid.pdc.kth.se> References: <199709232048.QAA03638@jenolan.rutgers.edu> X-SW-Source: 1997-09/msg00888.html That change is wrong. It is not the right way to fix the observed problem. Jeff, I think you should take it out again. Could you please tell me what specifically is wrong with the change? Sure. 1. It seems strange that convert_modes put a constant into a register. Maybe that is a bug. 2. If convert_modes is really right, the proper fix to expand_divmod would be to avoid calling it when op1 is constant. Torbjorn