program_transform_name

program_transform_name

[Chip Salzenberg]

While program_transform_name is set and used in the root Makefile,
it's not set properly in gcc/Makefile.  Here's a patch.

Index: gcc/Makefile.in
***************
*** 156,160 ****
  
  # Sed command to transform gcc to installed name.  Overwritten by configure.
! program_transform_name = -e s,x,x,
  program_transform_cross_name = -e s,^,$(target_alias)-,
  
--- 156,160 ----
  
  # Sed command to transform gcc to installed name.  Overwritten by configure.
! program_transform_name = @program_transform_name@
  program_transform_cross_name = -e s,^,$(target_alias)-,
  

-- 
Chip Salzenberg          - a.k.a. -           <chip@pobox.com>
        "He's Mr. Big of 'Big And Tall' fame."  // MST3K

Re: program_transform_name

[Jeffrey A Law]

  In message < 199709291237.IAA29662@rio.atlantic.net >you write:
  > While program_transform_name is set and used in the root Makefile,
  > it's not set properly in gcc/Makefile.  Here's a patch.
  > 
  > Index: gcc/Makefile.in
  > ***************
  > *** 156,160 ****
  >   
  >   # Sed command to transform gcc to installed name.  Overwritten by configu
  > re.
  > ! program_transform_name = -e s,x,x,
  >   program_transform_cross_name = -e s,^,$(target_alias)-,
  >   
  > --- 156,160 ----
  >   
  >   # Sed command to transform gcc to installed name.  Overwritten by configu
  > re.
  > ! program_transform_name = @program_transform_name@
  >   program_transform_cross_name = -e s,^,$(target_alias)-,
Don't you need to change configure/configure.in too?  Or am I
missing something?

jeff

Re: program_transform_name

[Chip Salzenberg]

According to Jeffrey A Law:
> Don't you need to change configure/configure.in too?

I guess it was already up-to-date; I didn't have to change it.
-- 
Chip Salzenberg          - a.k.a. -           <chip@pobox.com>
        "He's Mr. Big of 'Big And Tall' fame."  // MST3K

Re: program_transform_name

[Jeffrey A Law]

  In message < 199709291715.NAA18598@rio.atlantic.net >you write:
  > According to Jeffrey A Law:
  > > Don't you need to change configure/configure.in too?
  > 
  > I guess it was already up-to-date; I didn't have to change it.
My point was that I didn't see an AC_SUBST statement for
program_transform_name and I don't think it autoconf will change
the @program_transform_name@ into the right thing without it.

However, I'm not much of an autoconf person, so I could be wrong;
I just want someone to verify that the right thing will happen
if we put your change in.

jeff

Re: program_transform_name

[Akim Demaille]

Jeffrey A Law <law@cygnus.com> writes:

>   In message <199709291715.NAA18598@rio.atlantic.net>you write:
>   > According to Jeffrey A Law:
>   > > Don't you need to change configure/configure.in too?
>   > 
>   > I guess it was already up-to-date; I didn't have to change it.
> My point was that I didn't see an AC_SUBST statement for
> program_transform_name and I don't think it autoconf will change
> the @program_transform_name@ into the right thing without it.
> 
> However, I'm not much of an autoconf person, so I could be wrong;
> I just want someone to verify that the right thing will happen
> if we put your change in.

	For the autoconf side, the only thing to do is to drop
AC_ARG_PROGRAM
	somewhere, what enables the --program options to configure.

	Then you need to put the @program_transform_name@ somewhere in
the Makefile.

	Here are the relevant parts of autoconf's doc:

Transforming Program Names When Installing
==========================================

   Autoconf supports changing the names of programs when installing
them.  In order to use these transformations, `configure.in' must call
the macro `AC_ARG_PROGRAM'.

 - Macro: AC_ARG_PROGRAM
     Place in output variable `program_transform_name' a sequence of
     `sed' commands for changing the names of installed programs.

     If any of the options described below are given to `configure',
     program names are transformed accordingly.  Otherwise, if
     `AC_CANONICAL_SYSTEM' has been called and a `--target' value is
     given that differs from the host type (specified with `--host' or
     defaulted by `config.sub'), the target type followed by a dash is
     used as a prefix.  Otherwise, no program name transformation is
     done.

Transformation Rules
--------------------

   Here is how to use the variable `program_transform_name' in a
`Makefile.in':

     PROGRAMS=cp ls rm
     install:
             for p in $(PROGRAMS); do \
               $(INSTALL_PROGRAM) $$p $(bindir)/`echo $$p|sed '$(transform)'`; \
             done
     
     uninstall:
             for p in $(PROGRAMS); do \
               rm -f $(bindir)/`echo $$p|sed '$(transform)'`; \
             done



Regards,
	Akim

-- 
P-mail: Akim Demaille, 107 rue Bobillot, F-75013 Paris, France
E-mail: demaille@inf.enst.fr
V-mail: +33 (1) 45-81-78-68

Re: program_transform_name

[Ian Lance Taylor]

   Date: Tue, 30 Sep 1997 22:42:17 -0600
   From: Jeffrey A Law <law@cygnus.com>

     In message <199709291715.NAA18598@rio.atlantic.net>you write:
     > According to Jeffrey A Law:
     > > Don't you need to change configure/configure.in too?
     > 
     > I guess it was already up-to-date; I didn't have to change it.
   My point was that I didn't see an AC_SUBST statement for
   program_transform_name and I don't think it autoconf will change
   the @program_transform_name@ into the right thing without it.

autoconf always automatically substitutes for program_transform_name
(there is an AC_SUBST in acgeneral.m4).

However, there is a bigger simplification which I think should happen.
Right now gcc uses both program_transform_name and
program_transform_cross_name.  This is a manual implementation of
something that autoconf already provides via AC_ARG_PROGRAM.  I think
gcc should be changed to use AC_ARG_PROGRAM, and the install targets
should be simplified to eliminate program_transform_cross_name.

Chip's patch is still correct, but more work could be done in this
area.

Ian

Re: program_transform_name

[Jeffrey A Law]

  In message <199709291237.IAA29662@rio.atlantic.net>you write:
  > While program_transform_name is set and used in the root Makefile,
  > it's not set properly in gcc/Makefile.  Here's a patch.
Thanks.  I've installed this patch.
jeff